Skip to content

Extract authenticators to their own files - #22

Merged
nevans merged 3 commits into
masterfrom
extract-authenticators
May 5, 2021
Merged

Extract authenticators to their own files#22
nevans merged 3 commits into
masterfrom
extract-authenticators

Conversation

@nevans

@nevansnevans commented Apr 28, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

I've started down the path of implementing #10. This PR simply copies authenticators with some minor changes, but this raises a big issue I've been meaning to ask about: SASL. I'll open another issue to discuss that: #23. I'm marking this as a draft, pending that discussion.

In addition to moving the authenticators to new files, I've updated the rdoc and added authnid support for PLAIN.

@nevans
Move each authenticator to its own file
23f241b
Also updates rdoc with SASL specifications and deprecations. Of these
four, only `PLAIN` isn't deprecated!
+@@Authenticators+ was changed to a class instance var
+@Authenticators+. No one should have been using the class variable
directly, so that should be fine.
@nevans
Update AUTH=PLAIN to be a little closer to RFC4616
a587fc7
* Add authzid support
* must not contain NULL chars
* improve rdoc
@nevans
Clean up authenticators rdoc
53ff4b0
Added RFC links to all SASL mechanism specifications.
@nevans
nevans requested review from hsbt and shugoApril 28, 2021 22:55
@nevansnevans mentioned this pull request Apr 28, 2021
Open
5 tasks
@nevans
nevans marked this pull request as draft April 28, 2021 23:09
shugo
shugo approved these changes Apr 30, 2021
View reviewed changes

@shugoshugo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
@hsbt Do you have any considerations in terms of Ruby releases?

@hsbt

hsbt commented Apr 30, 2021

Copy link
Copy Markdown
Member

👍 It seems good practice for organizing code.

@nevans Can you also move net-imap.gemspec to under the net/imap dir?

@nevans

nevans commented Apr 30, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@nevans Can you also move net-imap.gemspec to under the net/imap dir?

If we move the gemspec, won't that break existing build scripts? In particular, it means that people won't be able to use the common pattern: gem 'net-imap', github: "ruby/net-imap", ref: .... They could add glob: 'lib/net/imap/*.gemspec' but that's a fairly uncommon option, especially when there's only one gem in the repo.

@nevans

nevans commented Apr 30, 2021

Copy link
Copy Markdown
CollaboratorAuthor

And... I only just discovered that bundler's default glob is "{,*,*/*}.gemspec". I'd assumed it was different, matching less. Still, that means the gemfile would need to be in the repo root or one dir down. Neither lib/net/imap/net-imap.gemspec nor net/imap/net-imap.gemspec would work. Am I misunderstanding something? 🙂

@nevans
nevans merged commit 53ff4b0 into masterMay 5, 2021
@nevans
nevans deleted the extract-authenticators branch May 5, 2021 20:13
@nevansnevans mentioned this pull request May 5, 2021
Closed
@hsbt

hsbt commented May 5, 2021

Copy link
Copy Markdown
Member

f we move the gemspec, won't that break existing build scripts?

Ah, Sorry. I meant it in ruby/ruby repo. There is no action with this repo.

@hsbt

hsbt commented May 6, 2021

Copy link
Copy Markdown
Member

I tweaked sync script at ruby/ruby@5de6f1a

@nevansnevans added the SASL 🔒 Authentication and authentication mechanisms label Feb 12, 2023
@nevansnevans mentioned this pull request Sep 20, 2023
Closed
37 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shugoshugoshugo approved these changes
@hsbthsbtAwaiting requested review from hsbt

Assignees

No one assigned

Labels

SASL 🔒Authentication and authentication mechanisms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nevans@hsbt@shugo