Skip to content

💥 Drop ruby 2.7 and 3.0 support, and require 3.1 - #276

Merged
nevans merged 2 commits into
ruby:masterfrom
nevans:require-ruby-3.1
Jun 23, 2024
Merged

💥 Drop ruby 2.7 and 3.0 support, and require 3.1#276
nevans merged 2 commits into
ruby:masterfrom
nevans:require-ruby-3.1

Conversation

@nevans

@nevansnevans commented May 2, 2024

Copy link
Copy Markdown
Collaborator

Ruby 2.7 EOL was 2023-03-31.
Ruby 3.0 EOL was 2024-04-23.

Currently, net-imap remains compatible with ruby 2.7. But some of my unmerged branches do use ruby 3.1 syntax (e.g: updated pattern matching and endless method definitions). It will be nice if I don't need to update those branches for compatibility with EOL rubies.


NOTE: The next release after this is merged should be v0.5.0.

@nevans
nevansforce-pushed the require-ruby-3.1 branch from 4f63422 to d663323CompareMay 2, 2024 12:44
@nevans

nevans commented May 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@shugo@hsbt Are you okay with bumping the minimum ruby version for the 0.5.x releases?

As a policy, I'd like to only change the minimum required ruby when we bump our major.minor version. And I'd like to only bump the major.minor version once a year, after the oldest version of ruby reaches its end of life. This way, net-imap's major.minor will be approximately synchronized with ruby's.

shugo
shugo previously approved these changes May 2, 2024

@shugoshugo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds reasonable 👍

hsbt
hsbt previously approved these changes May 2, 2024

@hsbthsbt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@nevans
nevansforce-pushed the require-ruby-3.1 branch 2 times, most recently from 1cf80d7 to 979d82fCompareMay 19, 2024 14:03
@nevansnevans added the v0.5 label May 19, 2024
@nevans
nevansforce-pushed the require-ruby-3.1 branch from 979d82f to 385c9d0CompareMay 19, 2024 14:19
@nevansnevans added this to the v0.5 milestone May 19, 2024
@nevansnevans removed the v0.5 label May 19, 2024
@nevans
nevansforce-pushed the require-ruby-3.1 branch 2 times, most recently from b86789f to b14a63dCompareJune 16, 2024 17:41
@nevansnevans mentioned this pull request Jun 22, 2024
The next release from the main branch will be 0.5.0.
@nevans
nevans dismissed stale reviews from shugo and hsbt via fead6a4June 23, 2024 01:42
Ruby 2.7 EOL was 2023-03-31.
Ruby 3.0 EOL was 2024-04-23.
Currently, net-imap remains compatible with ruby 2.7. But some of my
unmerged branches do use ruby 3.1 syntax (e.g: updated pattern matching
and endless method definitions). It will be nice if I don't need to
update those branches for compatibility with EOL rubies.
----
_**NOTE:** The next release after this is merged should be v0.5.0._
@nevans
nevans merged commit 37e50b3 into ruby:masterJun 23, 2024
@nevans
nevans deleted the require-ruby-3.1 branch June 23, 2024 01:51
@nevansnevans added the breaking-change Breaking change to publicly documented API label Feb 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changeBreaking change to publicly documented API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nevans@hsbt@shugo