Skip to content

⚡ Use frozen const when parsing empty arrays - #283

Draft
nevans wants to merge 1 commit into
ruby:masterfrom
nevans:parser/frozen-private-EMPTY_ARRAY-const
Draft

⚡ Use frozen const when parsing empty arrays#283
nevans wants to merge 1 commit into
ruby:masterfrom
nevans:parser/frozen-private-EMPTY_ARRAY-const

Conversation

@nevans

@nevansnevans commented May 19, 2024

Copy link
Copy Markdown
Collaborator

TODO:

NOTE: this will be considered a breaking change, because some libraries may rely on responses being mutable. (See e.g: #262) The kind thing to do would be to add a config var and a conditional, however that may impact performance... and performance is the primary reason for this PR. Maybe the mail gem will accept a PR to not mutate search responses?(done)

@nevansnevans added the v0.5 label May 19, 2024
@nevansnevans added this to the v0.5 milestone May 19, 2024
@nevansnevans removed the v0.5 label May 19, 2024
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch 3 times, most recently from fc08916 to 9771e1aCompareJune 22, 2024 16:16
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 9771e1a to 3b0bed8CompareJune 26, 2024 14:56
@nevansnevans modified the milestones: v0.5, v0.6Jun 29, 2024
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 3b0bed8 to 801b4aeCompareOctober 12, 2024 14:42
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 801b4ae to 090d11aCompareOctober 29, 2024 18:08
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 090d11a to 697fde6CompareNovember 8, 2024 22:59
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 697fde6 to 402a7bbCompareDecember 23, 2024 22:39
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 402a7bb to 0d5aaceCompareFebruary 13, 2025 14:53
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 0d5aace to 8266b94CompareApril 24, 2025 13:16
@nevansnevans removed this from the v0.6 milestone May 1, 2025
@nevansnevans added breaking-change Breaking change to publicly documented API performance related to CPU use, memory use, latency, etc labels Nov 10, 2025
@nevans
nevansforce-pushed the parser/frozen-private-EMPTY_ARRAY-const branch from 8266b94 to 5d6cadbCompareNovember 29, 2025 19:50
@nevansnevans added this to the v1.0 milestone Dec 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changeBreaking change to publicly documented APIperformancerelated to CPU use, memory use, latency, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@nevans