Skip to content

⬆️ Drop v2.6 support; Require v2.7.3; Use "..." arg - #89

Merged
nevans merged 1 commit into
masterfrom
require-2.7.3
Jan 6, 2023
Merged

⬆️ Drop v2.6 support; Require v2.7.3; Use "..." arg#89
nevans merged 1 commit into
masterfrom
require-2.7.3

Conversation

@nevans

@nevansnevans commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

Argument forwarding was the issue in #68, and we decided to require ruby 2.7 instead of adding ruby2_keywords.

If I remember correctly, v2.7.0-v2.7.2 didn't allow ... to be used with leading arguments, so this sets the minimum version to v2.7.3.

v2.7.0-v2.7.2, didn't allow "..." to be used with leading arguments, so
the minimum version is v2.7.3.

@shugoshugo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine!

@nevans
nevans merged commit 1c20813 into masterJan 6, 2023
@nevans
nevans deleted the require-2.7.3 branch January 6, 2023 22:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nevans@shugo