Uh oh!
There was an error while loading. Please reload this page.
Delegate checking auth args to the authenticator - #73
Merged
Conversation
nevansforce-pushed
the
sasl/delegate-check_auth_args
branch
from
October 14, 2023 18:09
cf5dca1 to
8d991c4Comparenevansforce-pushed
the
sasl/delegate-check_auth_args
branch
from
October 14, 2023 19:03
8d991c4 to
36d91caCompare
This was referenced Oct 14, 2023
nevansforce-pushed
the
sasl/delegate-check_auth_args
branch
from
October 15, 2023 01:54
36d91ca to
bb1f9d1CompareEach authenticator has different parameters, so argument validation must be delegated to the authenticator classes.
nevansforce-pushed
the
sasl/delegate-check_auth_args
branch
from
October 15, 2023 10:26
bb1f9d1 to
c02ce79Compare4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each authenticator has different parameters, so argument validation must be delegated to the authenticator classes.
This PR builds on #67 to avoid merge conflicts.