Skip to content

Implement Pathname#chdir - #33

Open
zverok wants to merge 1 commit into
ruby:masterfrom
zverok:feature-chdir
Open

Implement Pathname#chdir#33
zverok wants to merge 1 commit into
ruby:masterfrom
zverok:feature-chdir

Conversation

@zverok

@zverokzverok commented Dec 16, 2023

Copy link
Copy Markdown

As it was introduced into Ruby 3.3 as Dir#chdir, and was requested before that in #25.

@zverok
zverok requested a review from hsbtDecember 16, 2023 18:34
@zverokzverok self-assigned this Dec 16, 2023
olleolleolle
olleolleolle reviewed Dec 16, 2023
View reviewed changes
Comment threadext/pathname/pathname.c Outdated
{
VALUE args[1];

if(rb_block_given_p()) {

@olleolleolleolleolleolleDec 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Minor: is the if ( the style used in other conditionals in this file?

@zverokzverokDec 16, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, indeed! Thank you for noticing.

@toy

toy commented Dec 27, 2023

Copy link
Copy Markdown
Contributor

Pathname#chdir already existed in ruby till 1.9.1, was obsoleted in 1.8.1 preview and removed in 1.9.2 preview

@zverok

zverok commented Dec 27, 2023

Copy link
Copy Markdown
Author

@toy Interesting. Do you know the justification? (The obsoleting commit doesn't link to the tracker ticket or ruby-core email discussion) 🤔

@toy

toy commented Dec 27, 2023

Copy link
Copy Markdown
Contributor

@zverok I remember being frustrated about the change and that justification was something about the method being misplaced, but I failed now to find any more information about it

@hsbt

hsbt commented Dec 27, 2023

Copy link
Copy Markdown
Member

https://blade.ruby-lang.org/ruby-core/21564

@toy

toy commented Dec 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@hsbt That one is about removal of methods already marked obsolete, but not why were they marked obsolete

@zverok

zverok commented Sep 26, 2024

Copy link
Copy Markdown
Author

@hsbt Any updates on this?.. It is a bit weird now that (more simple) Dir object has this method after Ruby 3.3, but (more advanced) Pathname doesn’t.

@hsbt

hsbt commented Oct 4, 2024

Copy link
Copy Markdown
Member

see #25 (comment)

@zverokzverok mentioned this pull request Oct 5, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsbthsbtAwaiting requested review from hsbt
1 more reviewer
@olleolleolleolleolleolleolleolleolle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@zverokzverok

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zverok@toy@hsbt@olleolleolle