Uh oh!
There was an error while loading. Please reload this page.
Fixes for Data and add TruffleRuby in CI - #20
Merged
Conversation
This was referenced Nov 30, 2023
* Data#members might not be defined, instead it might be defined on Data subclasses or a module included there. This is notably the case on TruffleRuby which defines it there for optimization purposes. In fact the mere presence of Data#members implies a megamorphic call inside, so it seems best to avoid relying on its existence.
…nymous * It would be "#<data a=42>" (double space) instead of "#<data a=42>" (like #inspect).
* Only 2 cyclic tests are failing, with the ... in a slightly different place in the output.
eregon
commented
Jan 11, 2024
MemberAuthor
No review in a while, I'll merge this, it seems an obvious improvement. |
nobu
commented
Oct 4, 2025
Member
This causes a warning with ruby 2.7. $ ruby2.7 -w -e 'gem "pp"; require "pp"'/opt/local/lib/ruby2.7/gems/2.7.0/gems/pp-0.6.2/lib/pp.rb:487: warning: constant ::Data is deprecated
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.