Uh oh!
There was an error while loading. Please reload this page.
Only skip specific failures on JRuby instead of ignoring the whole CI feedback - #524
Conversation
deivid-rodriguez
commented
Oct 12, 2021
This PR is just to proof that the changes work, but it should not be merged. Once jruby/ruby-maven#2 is merged and released, things should start working without any changes. |
1ae0ce1 to
d9838a1Comparedeivid-rodriguez
commented
Nov 24, 2021
Alright so dependent PRs are moving forward, and this is now only missing a However, the gem became uninstallable again on |
d9838a1 to
b1babf2Compareb1babf2 to
89cb668Compareheadius
commented
Sep 19, 2022
This would be worth revisiting with latest SnakeYAML. On master, I now see 5F7E. Some of these may be valid differences (SnakeYAML appears to report line/column positioning a bit differently) but several appear to be fixable errors or bugs. We also addressed the stringio gemification for JRuby 9.4. |
88771f8 to
861dee4Comparedeivid-rodriguez
commented
Sep 27, 2022
@headius I completely lost context of this PR. I think the original issues I wanted to address are now fixed, but a few others remain. I changed the scope of this PR to:
Let's see what CI says. |
deivid-rodriguez
commented
Sep 27, 2022
Except for the specs that are marked as pending, everything is now green on JRuby, so I set this as ready for review. |
headius
commented
Sep 27, 2022
@deivid-rodriguez Very nice! Good idea to skip some tests that are problematic... some might not be fixable due to minor differences in SnakeYAML (positioning information etc). @tenderlove Any objections to merging this PR? It marks a number of tests as pending, but I'm not sure they are fixable and it would be good to have a green-ish run so we can see when things regress. |
This way we should be able to prevent new regressions from being introduced.
hsbt
commented
Oct 7, 2022
@deivid-rodriguez 👍 Thanks! |
This PR is just some experiment to proof that jruby/ruby-maven#2 fixes:
bundle installfails).