Uh oh!
There was an error while loading. Please reload this page.
Ensure strings that may be confused as YAML1.2 numbers are quoted - #628
Open
adammw wants to merge 1 commit into
Open
Ensure strings that may be confused as YAML1.2 numbers are quoted#628adammw wants to merge 1 commit into
adammw wants to merge 1 commit into
Conversation
nobu
reviewed
Jun 8, 2023
Uh oh!
There was an error while loading. Please reload this page.
djhoese
commented
Oct 9, 2024
@adammw Any chance you have time to continue working on this? I've run into this same problem where strings (git commit SHAs) that look like scientific notation are dumped with no quotes around them. |
adammw
commented
Dec 5, 2024
Author
@djhoese Ironically that's the exact reason I started looking into this 😅 but also why it's been pretty low priority, the "solution" is just to rewrite the commit to get a different SHA so it doesn't hit this condition |
adammwforce-pushed
the
adammw/yaml12-number
branch
from
December 5, 2024 06:14
5279e18 to
21eb63fCompareadammwforce-pushed
the
adammw/yaml12-number
branch
from
December 5, 2024 06:15
21eb63f to
cce65ccCompareCarlosCD
commented
May 15, 2025
This seems to solve #701 as well ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure strings that may be confused as YAML1.2 numbers are quoted.
Example:
0o123or1e3strings in Ruby will be printed without quotation marks, resulting in them changing to numbers in a YAML1.2-parser (like that used in Go).Fixes#627