Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/libfyaml.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
name: libfyaml

on:
push:
pull_request:
schedule:
- cron: '33 11 * * 0'
workflow_dispatch:

# Exercises the experimental, opt-in libfyaml backend (--enable-libfyaml).
# libfyaml is not supported on Windows, so this workflow runs on Linux and
# macOS only. The default libyaml backend is covered by test.yml/libyaml.yml.
jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0

build:
needs: ruby-versions
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]

env:
LIBFYAML_VERSION: "0.9.6"

steps:
- uses: actions/checkout@v7.0.0
- name: Set up Ruby and libfyaml
uses: ruby/setup-ruby-pkgs@v1
with:
ruby-version: ${{ matrix.ruby }}
apt-get: "pkg-config"
brew: "libfyaml pkg-config"
- name: Build libfyaml from source
# The libfyaml-dev package on Ubuntu is 0.8, which crashes the emitter,
# so build a known-good release. macOS uses the Homebrew build above.
if: runner.os == 'Linux'
run: |
curl -fsSL "https://github.com/pantoniou/libfyaml/releases/download/v${LIBFYAML_VERSION}/libfyaml-${LIBFYAML_VERSION}.tar.gz" | tar xz
cd "libfyaml-${LIBFYAML_VERSION}"
./configure --prefix=/usr/local
make -j"$(nproc)"
sudo make install
sudo ldconfig
- name: Install dependencies
run: bundle install --jobs 3
- name: Compile with the libfyaml backend
run: rake compile -- --enable-libfyaml
- name: Verify the libfyaml backend is active
run: |
ruby -Ilib -rpsych -e 'abort "expected the libfyaml backend, got #{Psych::BACKEND}" unless Psych::BACKEND == "libfyaml"'
ruby -Ilib -rpsych -e 'puts "libfyaml #{Psych.libfyaml_version}"'
- name: Run test
run: rake test
53 changes: 53 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ Psych.dump("foo") # => "--- foo\n...\n"
## Dependencies

* libyaml
* libfyaml (optional, only for the experimental `--enable-libfyaml` backend)

## Installation

Expand DownExpand Up@@ -57,6 +58,58 @@ gem 'psych'

JRuby ships with a pure Java implementation of Psych.

## Experimental libfyaml backend

Psych ships an experimental, opt-in backend built on
[libfyaml](https://github.com/pantoniou/libfyaml), a fully YAML 1.2 compliant
parser and emitter. It is compiled only when you explicitly pass
`--enable-libfyaml` at build time. Without the flag the default libyaml
backend is used and nothing changes.

```bash
# libfyaml and pkg-config must be installed first, for example:
# apt-get install libfyaml-dev # Debian/Ubuntu
# brew install libfyaml # macOS
gem install psych -- --enable-libfyaml
```

This backend is not supported on Windows.

Because libfyaml follows YAML 1.2, the YAML 1.1 booleans `yes`, `no`, `on`, and
`off` load as plain strings instead of `true`/`false` (only `true`/`false` are
booleans). This resolves the so-called "Norway problem", where the country
code `no` was parsed as `false`:

```ruby
Psych.load("country: no") # => {"country" => "no"}
```

You can check which backend is active:

```ruby
Psych::BACKEND # => "libfyaml" (or "libyaml")
Psych.libfyaml_version # => "0.9.6"
```

The backend is experimental. Its output is valid YAML but is formatted
differently from libyaml in places, and a few emitter edge cases are not yet
matched. The default libyaml backend remains the supported choice.

Two more differences are worth knowing. Scalars emitted with the default
(`ANY`) style may be quoted or laid out differently from libyaml, so
byte-for-byte output is not guaranteed to match. On a parse error,
`Psych::SyntaxError#problem` carries libfyaml's full diagnostic message and
`Psych::SyntaxError#context` is always `nil`, whereas libyaml splits the
description across `#problem` and `#context`.

This backend targets YAML 1.2 compliance, not speed. In a rough
single-machine benchmark that loads and dumps in-memory documents, parsing
was roughly on par with libyaml (sometimes faster on string-heavy input),
while emitting was about 1.7x to 1.9x slower. Your numbers will vary, but the
shape holds: libfyaml is competitive at parsing and slower at emitting. Use
this backend when you need YAML 1.2 semantics. If throughput is your priority,
keep using the default libyaml backend.

## Release

We used the trusted publisher and [rubygems/release-gem](https://github.com/rubygems/release-gem) workflow.
Expand Down
22 changes: 22 additions & 0 deletions ext/psych/extconf.rb
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,28 @@
# frozen_string_literal: true
require 'mkmf'

# Experimental, opt-in libfyaml backend. Only used when psych is built with
# --enable-libfyaml. Without the flag nothing below changes and the default
# libyaml backend is built exactly as before.
if enable_config("libfyaml", false)
if $mswin or $mingw or $cygwin
abort "The libfyaml backend (--enable-libfyaml) is not supported on Windows"
end
unless pkg_config('libfyaml')
abort "libfyaml was requested with --enable-libfyaml but was not found via pkg-config"
end
# libfyaml 0.8 and earlier crash psych's emitter, so require a known-good
# version rather than building something that segfaults at runtime.
pkgconfig = ENV["PKG_CONFIG"] || "pkg-config"
unless system(pkgconfig, "--atleast-version=0.9", "libfyaml")
abort "The libfyaml backend requires libfyaml 0.9 or newer"
end
$defs << "-DPSYCH_USE_LIBFYAML"

create_makefile 'psych'
return
end

if $mswin or $mingw or $cygwin
$CPPFLAGS << " -DYAML_DECLARE_STATIC"
end
Expand Down
34 changes: 33 additions & 1 deletion ext/psych/psych.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@

/* call-seq: Psych.libyaml_version
*
* Returns the version of libyaml being used
* Returns the version of the underlying YAML library as a three-element
* array. This is libyaml by default. On the experimental libfyaml backend,
* where libyaml is not linked, it reports the libfyaml version instead.
*/
static VALUE libyaml_version(VALUE module)
{
int major, minor, patch;
VALUE list[3];

#ifdef PSYCH_USE_LIBFYAML
/* Experimental libfyaml backend: there is no libyaml linked in. Report
* the libfyaml version so callers still receive a 3-element version. */
const struct fy_version *v = fy_version_default();
major = v ? v->major : 0;
minor = v ? v->minor : 0;
patch = 0;
Comment thread
hsbt marked this conversation as resolved.
#else
yaml_get_version(&major, &minor, &patch);
#endif

list[0] = INT2NUM(major);
list[1] = INT2NUM(minor);
Expand All@@ -18,6 +29,20 @@ static VALUE libyaml_version(VALUE module)
return rb_ary_new4((long)3, list);
}

#ifdef PSYCH_USE_LIBFYAML
/* call-seq: Psych.libfyaml_version
*
* Returns the libfyaml version string. This method is only defined when
* psych was built with the experimental libfyaml backend
* (+--enable-libfyaml+).
*/
static VALUE libfyaml_version(VALUE module)
{
const char *v = fy_library_version();
return v ? rb_usascii_str_new2(v) : Qnil;
}
#endif

VALUE mPsych;

void Init_psych(void)
Expand All@@ -29,6 +54,13 @@ void Init_psych(void)

rb_define_singleton_method(mPsych, "libyaml_version", libyaml_version, 0);

#ifdef PSYCH_USE_LIBFYAML
rb_define_singleton_method(mPsych, "libfyaml_version", libfyaml_version, 0);
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libfyaml"));
#else
rb_define_const(mPsych, "BACKEND", rb_usascii_str_new2("libyaml"));
#endif

Init_psych_parser();
Init_psych_emitter();
Init_psych_to_ruby();
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,11 @@
#include <ruby.h>
#include <ruby/encoding.h>

#ifdef PSYCH_USE_LIBFYAML
#include <libfyaml.h>
#else
#include <yaml.h>
#endif

#include <psych_parser.h>
#include <psych_emitter.h>
Expand Down
4 changes: 4 additions & 0 deletions ext/psych/psych_emitter.c
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
#include <psych.h>

#ifndef PSYCH_USE_LIBFYAML

#if !defined(RARRAY_CONST_PTR)
#define RARRAY_CONST_PTR(s) (const VALUE *)RARRAY_PTR(s)
#endif
Expand DownExpand Up@@ -587,3 +589,5 @@ void Init_psych_emitter(void)
id_indentation = rb_intern("indentation");
id_canonical = rb_intern("canonical");
}

#endif /* PSYCH_USE_LIBFYAML */
Loading
Loading