Uh oh!
There was an error while loading. Please reload this page.
Get JRuby green and run it in CI - #93
Merged
Merged
Conversation
This was referenced Nov 19, 2018
flavorjones added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Nov 19, 2018
flavorjones
commented
Nov 19, 2018
Collaborator
headius pushed a commit
to headius/racc
that referenced
this pull request
Feb 6, 2019
Get JRuby green and run it in CI
headius
commented
Feb 7, 2019
ContributorAuthor
@flavorjones Thanks, I don't remember any particular reason I requested review from you, but thanks for the input all the same! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP to get some JRuby fixes in place to make tests green and enable testing of JRuby in CI.
There's one issue fixed in the initial commits: catch logic and the REDUCE macro were implemented incorrectly.
Other issues will be filed separately and combined into this PR until everything's good to go.