Skip to content

Add support for itunes episode & season - #31

Merged
kou merged 7 commits into
ruby:masterfrom
saerdnaer:itunes-episode-season
May 3, 2021
Merged

Add support for itunes episode & season#31
kou merged 7 commits into
ruby:masterfrom
saerdnaer:itunes-episode-season

Conversation

@saerdnaer

@saerdnaersaerdnaer commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@olleolleolle

olleolleolle commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

I was able to locate the information about Apple's podcasting RSS requirements: https://help.apple.com/itc/podcasts_connect/#/itcb54353390

olleolleolle
olleolleolle suggested changes Apr 29, 2021
View reviewed changes

@olleolleolleolleolleolle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw two tiny typos when running the CI job.

Cool feature.

Comment threadtest/test-itunes.rb Outdated
Comment threadtest/test-itunes.rb Outdated
@koukou changed the title support for itunes episode & seasonAdd support for itunes episode & seasonApr 29, 2021
@kou

kou commented Apr 29, 2021

Copy link
Copy Markdown
Member

It seems that both of <itunes:episode> and <itunes:season> should exist in item not channel.

It seems that both of them needs validation (a non-zero integer). Do you want me to take over it?

@saerdnaer

saerdnaer commented May 1, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@kou Yes thats, right. I just found this commit in one of the forks and thought this should go upstream. Feel free to take it over.

Edit: fixed it myself.

dnlrnstlffand others added 2 commits May 3, 2021 00:28
@dnlrnstlff@saerdnaer
support for itunes episode & season
67c69d9
@saerdnaer@olleolleolle
Apply suggestions from code review
4e1fce7
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@saerdnaer
saerdnaerforce-pushed the itunes-episode-season branch from cf676d5 to d637cf8CompareMay 2, 2021 22:30
@saerdnaer
saerdnaerforce-pushed the itunes-episode-season branch from d637cf8 to 74e88f6CompareMay 2, 2021 22:38
@saerdnaer
saerdnaerforce-pushed the itunes-episode-season branch from d37541a to 1f74916CompareMay 2, 2021 23:02
@kou
kou merged commit 05cbfaa into ruby:masterMay 3, 2021
@kou

kou commented May 3, 2021

Copy link
Copy Markdown
Member

I've fixed a bug that channel still parses episode and season.
I've also added non zero positive integer validation.

I've merged. Thanks.

@saerdnaer
saerdnaer deleted the itunes-episode-season branch May 3, 2021 12:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olleolleolleolleolleolleAwaiting requested review from olleolleolle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saerdnaer@olleolleolle@kou@dnlrnstlff