Uh oh!
There was an error while loading. Please reload this page.
itunes: support for lowercased episodeType values - #48
Conversation
kou
commented
Dec 29, 2023
I can understand what you think but please disable validation for this case. (And please feedback this to fireside.fm if you want.) In general, feed readers parse feed loosely as much as possible because there are many broken feeds in the world and feed readers needs to process them as much as possible. |
| def #{name}=(new_value) | ||
| if @do_validate and | ||
| !["Full", "Trailer", "Bonus", nil].include?(new_value) | ||
| !["full", "trailer", "bonus", nil].include?(new_value.downcase) |
There was a problem hiding this comment.
Could you accept only Full/full variants? (We don't want to accept FULL, fULL and so on.
| !["full","trailer","bonus",nil].include?(new_value.downcase) | |
| !["Full","full","Trailer","trailer","Bonus","bonus",nil].include?(new_value) |
kou
commented
May 25, 2024
Apple uses |
kou
commented
Aug 2, 2024
Implemented by #53. |
I met this issue with following RSS: https://feeds.fireside.fm/smartlogic/rss
They uses lowercase values for episodeType like 'trailer' or 'full'. I tried 2 different RSS readers with the URL and all of them read this feed without problems (liferea and some from flatpack, forget the name).
ruby/rss raises exception:
I also tried RSS validator, and it gave many errors but not about episodeType value: https://www.rssboard.org/rss-validator/check.cgi?url=https%3A%2F%2Ffeeds.fireside.fm%2Fsmartlogic%2Frss
Hence I understood that official specs defines Full, Trailer and Bonus as legal values for this XML tag, but looks like it's already common practice to use lowercase values (even validator doesn't think it's bad)
So here is the patch to support them + small test update with lowercase value