Skip to content

Add Random::Formatter#phrase - #3

Closed
nobu wants to merge 2 commits into
ruby:masterfrom
nobu:random-phrase
Closed

Add Random::Formatter#phrase#3
nobu wants to merge 2 commits into
ruby:masterfrom
nobu:random-phrase

Conversation

@nobu

@nobunobu commented Aug 24, 2021

Copy link
Copy Markdown
Member

The method generates a random pass phrase.

@nobu
nobuforce-pushed the random-phrase branch 2 times, most recently from ca1f77d to 30b7397CompareDecember 6, 2021 07:25
Comment threadlib/random/formatter.rb Outdated
nobuand others added 2 commits December 30, 2023 00:02
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
PUNCT = %w[! - + / . ^ ~].freeze

# Default excluded characters for #phrase
EXCLUDE = %w"0 O o 1 l".freeze

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Is there a specific style reason to have another %w list delimiter for EXCLUDE than what PUNCT is using?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course nothing ;)

@nobu

nobu commented Jan 3, 2024

Copy link
Copy Markdown
MemberAuthor

It may be nice if this method accepts chars:, like as Random::Formatter#alphanumeric.

@jjbjjb mentioned this pull request Nov 6, 2024
@hsbt

hsbt commented Dec 16, 2024

Copy link
Copy Markdown
Member

Random::Formatter is removed from securerandom gem. I'll close this.

@hsbthsbt closed this Dec 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nobu@hsbt@olleolleolle