Uh oh!
There was an error while loading. Please reload this page.
#557 [Ruby 2.5] Update specs to use frozen_error_class for FrozenError - #568
Merged
Conversation
Atul9force-pushed
the
frozen_error_class
branch
2 times, most recently
from
December 19, 2017 05:17
eb2bd4b to
1ba2331Compareeregon
reviewed
Dec 19, 2017
| it "raises a RuntimeError if the object passed is frozen" do | ||
| lambda { @o.rb_obj_taint("".freeze) }.should raise_error(RuntimeError) | ||
| it "raises a FrozenError if the object passed is frozen" do |
ContributorAuthor
There was a problem hiding this comment.
done. I have updated the PR.
| describe "rb_check_frozen" do | ||
| it "raises a RuntimeError if the obj is frozen" do | ||
| lambda { @o.rb_check_frozen("".freeze) }.should raise_error(RuntimeError) | ||
| it "raises a frozen_error_class if the obj is frozen" do |
ContributorAuthor
There was a problem hiding this comment.
done. I have updated the PR.
| end | ||
| it "raises a RuntimeError if the array is frozen" do | ||
| it "raises a FrozenError if the array is frozen" do |
ContributorAuthor
There was a problem hiding this comment.
done. I have updated the PR.
Atul9force-pushed
the
frozen_error_class
branch
from
December 19, 2017 16:05
1ba2331 to
43da9f0Compare61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#557