Skip to content

Split examples to each sub sections - #753

Merged
eregon merged 1 commit into
ruby:masterfrom
nobu:feature/refine-CONTRIBUTING
Feb 9, 2020
Merged

Split examples to each sub sections#753
eregon merged 1 commit into
ruby:masterfrom
nobu:feature/refine-CONTRIBUTING

Conversation

@nobu

@nobunobu commented Feb 9, 2020

Copy link
Copy Markdown
Member

No description provided.

@eregoneregon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon
eregon merged commit 7b73996 into ruby:masterFeb 9, 2020
Comment threadCONTRIBUTING.md
# To avoid! Instead, use an expectation testing what the code in the lambda does.
# If an exception is raised, it will fail the example anyway.
**To avoid!** Instead, use an expectation testing what the code in the lambda does.
If an exception is raised, it will fail the example anyway.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably I should deprecate should_not raise_error.
However, there are 176 occurrences in ruby/spec to fix first :/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nobu
nobu deleted the feature/refine-CONTRIBUTING branch February 29, 2020 02:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nobu@eregon