Skip to content

Add a comment to explicit RUBY_FL_USER2 | RUBY_FL_USER3 - #133

Merged
byroot merged 1 commit into
ruby:masterfrom
byroot:chilled-str-comment
May 13, 2025
Merged

Add a comment to explicit RUBY_FL_USER2 | RUBY_FL_USER3#133
byroot merged 1 commit into
ruby:masterfrom
byroot:chilled-str-comment

Conversation

@byroot

@byrootbyroot commented May 13, 2025

Copy link
Copy Markdown
Member

This way when someone removes these flags from Ruby or update them, they'll find this reference when greping.

Followup: #128

@jeremyevans@kou

kou
kou approved these changes May 13, 2025
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment threadext/stringio/stringio.c Outdated
@byroot
Add a comment to explicit RUBY_FL_USER2 | RUBY_FL_USER3
f8976b6
This way when someone removes these flags from Ruby or update
them, they'll find this reference when greping.
@byroot
byrootforce-pushed the chilled-str-comment branch from 16edd90 to f8976b6CompareMay 13, 2025 07:52
@byroot
byroot merged commit fad26ee into ruby:masterMay 13, 2025
matzbot pushed a commit to ruby/ruby that referenced this pull request May 13, 2025
@byroot@matzbot
[ruby/stringio] Add a comment to explicit RUBY_FL_USER2 |
9420fc8
RUBY_FL_USER3
(ruby/stringio#133)
This way when someone removes these flags from Ruby or update them,
they'll find this reference when greping.
Followup: ruby/stringio#128ruby/stringio@fad26ee14b
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyevansjeremyevansjeremyevans approved these changes
@koukoukou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@byroot@jeremyevans@kou