Uh oh!
There was an error while loading. Please reload this page.
reset buffer's code range on read (jruby) - #156
Conversation
headius
left a comment
There was a problem hiding this comment.
Good catch... these modifies should all be clearing codeRange too. Just one typo to fix and this can merge.
Uh oh!
There was an error while loading. Please reload this page.
kares
commented
Nov 4, 2025
🔴 failures don't seem related, same happens on master |
kou
commented
Nov 4, 2025
Right. We should fix them in a separated PR. |
Uh oh!
There was an error while loading. Please reload this page.
headius
commented
Nov 4, 2025
All good here! @kou I can release or you can do it, let me know. |
kou
commented
Nov 5, 2025
You can do it! |
headius
commented
Nov 5, 2025
@kou Oh, I thought I had push privileges for the gem but I guess I do not! |
kou
commented
Nov 5, 2025
We have trusted publishing configuration in our CI. So we can push this gem by pushing release note https://github.com/ruby/stringio/blob/master/NEWS.md and running Do you want me to release a new version? |
headius
commented
Nov 5, 2025
Oh yes, I forgot about that. I can push a release. Thank you for the help! |
headius
commented
Nov 5, 2025
I'm sorry, on second thought I am unsure how to proceed. I see there are release commits against NEWS.md, but not all of them are tagged, and there's been a lot of changes since April. As I have never done a release of StringIO this way before, perhaps you could do this one and educate me on the process? |
kou
commented
Nov 9, 2025
OK. I'll release a new version in a few days. |
kou
commented
Nov 12, 2025
Done. |
as mentioned in the commit and visible from the test,
StringIO#readsuffers from the same issue as jruby/jruby#9035