Uh oh!
There was an error while loading. Please reload this page.
Add workflow to ensure the gem installs fine on truffleruby - #74
Merged
Conversation
41 tasks
kou
commented
Nov 29, 2023
Member
How about just changing existing workflow? diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
index 361a4eb..60557d0 100644
--- a/.github/workflows/ubuntu.yml+++ b/.github/workflows/ubuntu.yml@@ -42,5 +42,12 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
- name: Run test
+ # TODO+ if: >-+ matrix.ruby != 'truffleruby-head'
run: bundle exec rake
continue-on-error: ${{ startsWith(matrix.ruby, 'jruby') }}
+ - name: Install gem+ run: |+ gem install pkg/*.gem+ ruby -rstringio -e 'puts(StringIO::VERSION)' |
eregon
commented
Nov 29, 2023
MemberAuthor
OK, I'll do that. |
eregonforce-pushed
the
truffleruby-workflow
branch
from
November 29, 2023 11:51
131f483 to
bc6a567Compareeregon
commented
Nov 29, 2023
Comment on lines
+45
to
+47
| # Tests don't pass yet on truffleruby | ||
| if: >- | ||
| matrix.ruby != 'truffleruby-head' |
MemberAuthor
There was a problem hiding this comment.
We could also use continue-on-error like for jruby just below, not sure what is best.
Member
There was a problem hiding this comment.
Right. I don't have an opinion for this. You can choose whichever you like.
eregon
commented
Nov 29, 2023
MemberAuthor
@kou Done, and CI passing |
kou
approved these changes
Nov 29, 2023
| - name: Install gem | ||
| run: | | ||
| gem install pkg/*.gem | ||
| ruby -rstringio -e 'puts StringIO::VERSION' |
Member
There was a problem hiding this comment.
Just for confirmation: This outputs 3.0.1 (not 3.1.1) on truffleruby-head. It's intentional, right?
https://github.com/ruby/stringio/actions/runs/7032124053/job/19135198739?pr=74#step:9:9
3.0.1
MemberAuthor
There was a problem hiding this comment.
Yes, because it uses truffleruby's stringio.rb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #71.
As explained there we can't run the full test suite on truffleruby yet.
But we can test that the gem installs fine on TruffleRuby, which is already valuable.