Skip to content

Fix tracked file paths for subdirectories - #103

Merged
perryqh merged 1 commit into
rubyatscale:mainfrom
klly14:codex/fix-tracked-files-subdirectory
Apr 13, 2026
Merged

Fix tracked file paths for subdirectories#103
perryqh merged 1 commit into
rubyatscale:mainfrom
klly14:codex/fix-tracked-files-subdirectory

Conversation

@klly14

Copy link
Copy Markdown
Contributor

Summary

  • remove --full-name from git ls-files so tracked paths stay relative to the supplied base_path
  • add a regression test covering find_tracked_files when called from a subdirectory inside a git repo

Root cause

git ls-files --full-name always emits paths relative to the repository root. find_tracked_files then joined those repo-root-relative paths onto base_path, which doubled nested prefixes like /repo/backend/backend/... when the caller ran from a subdirectory.

Validation

  • cargo test tracked_files -- --nocapture
  • cargo test
  • cargo fmt --check

@klly14klly14 changed the title [codex] Fix tracked file paths for subdirectoriesFix tracked file paths for subdirectoriesApr 7, 2026
@klly14
klly14 marked this pull request as ready for review April 7, 2026 02:04
@klly14
klly14 requested a review from a team as a code ownerApril 7, 2026 02:04
@dduugg
dduugg requested a review from perryqhApril 13, 2026 20:09

@perryqhperryqh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perryqh
perryqh merged commit 8f93ca8 into rubyatscale:mainApr 13, 2026
@github-project-automationgithub-project-automationBot moved this from Triage to Done in ModularityApr 13, 2026
@perryqhperryqh mentioned this pull request Apr 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@klly14@perryqh