Preserve internal comment draft across reloads by unasuke · Pull Request #1133 · rubycentral/cfp-app

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke · 2026-07-10T15:36:24Z

What

Add a comment-draft Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior.

Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text.

Screenshots

comment succeeded

2026-07-24.141551.mp4

comment failed

2026-07-24.141844.mp4

amatsuda · 2026-07-11T03:41:23Z

@unasuke I suppose #1134 would solve 95% of your problem. Can you take a look at that patch? Still with the patch, the form content may disappear if the user hard-reloads the browser, but that's just how the browsers work. I don't think that's something the app developers should deal with.

Star-rating clicks used to re-render the whole rating widget, clobbering any internal-comment draft mid-typing (the motivating gap in PR #1133's localStorage approach). The rating form now lives in a nested rating_form frame; the controller responds with Turbo Streams so each transition replaces exactly what it changes: score updates swap only the rating form, while the first rating and rating removal still replace the whole widget (they toggle the internal-comments block's visibility). A localStorage layer for true page reloads (PR #1133) remains complementary; with this change it no longer needs to compensate for in-page re-renders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Add a `comment-draft` Stimulus controller that saves the internal comment textarea to localStorage (debounced on input) and restores it on reconnect, mirroring GitHub's issue/PR comment draft behavior. Since CommentsController redirect_backs on both success and validation failure, turbo:submit-end can't distinguish them. Clear the draft optimistically on submit-start and restore it only on a failed request (success === false), which also avoids the re-render race where a reconnected controller would otherwise restore the just-submitted text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

unasuke · 2026-07-24T05:21:01Z

@amatsuda #1134 already solved the biggest cause (a rating click wiping the writing comment), and this branch sits on top of it.

The remaining case I'd like to cover is not so much hard reloads as failed submissions: very occasionally posting a comment fails (a network error or a server error), and when that happens the typed comment is simply gone.
This patch the draft is kept in localStorage and only cleared once the submission actually succeeds, so a failed post no longer costs you the text.

unasuke force-pushed the preserve-internal-comment branch from 59c46c3 to 982843fCompare July 10, 2026 15:37

amatsuda mentioned this pull request Jul 11, 2026
Scope rating submissions to their own turbo frame #1134
Merged

unasuke marked this pull request as draft July 11, 2026 04:04

unasuke force-pushed the preserve-internal-comment branch from 982843f to 11a7afbCompare July 13, 2026 07:53