Skip to content

Multiline Inline Diff - #99

Merged
korny merged 7 commits into
rubychan:masterfrom
Eric-Guo:multiline-inline-diff
Mar 10, 2013
Merged

Multiline Inline Diff#99
korny merged 7 commits into
rubychan:masterfrom
Eric-Guo:multiline-inline-diff

Conversation

@korny

Copy link
Copy Markdown
Member

This solves #69.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this about?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of scanners don't keep their state around yet. Most don't even use the state protocol. It's a TODO, related but not essential for this feature.

@ghostghost assigned kornyNov 13, 2012
@korny

korny commented Mar 4, 2013

Copy link
Copy Markdown
MemberAuthor

I definitely want to merge this, but we should fix the keep_state problem on all scanners, too. I'll open a ticket.

@korny
korny merged commit 5c5954d into rubychan:masterMar 10, 2013
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@korny@nathany