Uh oh!
There was an error while loading. Please reload this page.
chore: bump rubykatzen/baseline to v0.13.1, drop redundant actionlint ignore - #112
Merged
Conversation
… ignore v0.13.1 added its own -ignore for the workflow_(repository|sha) property gap directly in hooks/actionlint.sh, so the repo-local .github/actionlint.yaml ignore for the same pattern (added back when we were still on v0.13.0, before baseline covered it) is now dead weight. Confirmed by running pre-commit against the bumped hook without the local ignore file present - still clean.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#105.
v0.13.1 added its own
-ignoreforworkflow_(repository|sha)directly inhooks/actionlint.sh(confirmed by diffing that file at v0.13.0 vs v0.13.1). This repo's local.github/actionlint.yamlcarried the same ignore as a workaround from back when we were still on v0.13.0, before baseline covered it — now redundant.Bumps the pin in all four
rubykatzen/baseline/.github/workflows/*-shared.yml@vXcallers plus.pre-commit-config.yaml'srev:, and deletes.github/actionlint.yamloutright rather than leaving a vestigial empty file.Verification
pre-commit run --all-filesagainst the actual v0.13.1 hook environment, with the local ignore file already removed — still clean, confirming the redundancy claim rather than just asserting it.Closes#105.