Skip to content

refactor: move Telegram chat ID to variable#178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ineedjet merged 3 commits into from
Aug 29, 2026
Merged

refactor: move Telegram chat ID to variable #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b104b75
refactor: move Telegram chat ID to variable
ineedjet Aug 29, 2026
f86282a
fix: read Telegram chat variable in notification steps
ineedjet Aug 29, 2026
4959a1f
refactor: use Baseline Telegram chat input
ineedjet Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/deploy/README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ jobs:
with:
message: "Deploy: ${{ matrix.name }} updated"
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
telegram-chat-id: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
```

Unlike a `workflow_call` reusable workflow, this action doesn't check out anything itself - it reads `target-manifest` from whatever the caller's own preceding `actions/checkout` step already put on disk, and its own code (`deploy.py` and friends) comes along automatically via `$GITHUB_ACTION_PATH` whenever it's referenced as `owner/repo/.github/actions/deploy@ref`. This is also why there's no `target-manifest-ref` input here: if the caller needs a specific ref (e.g. a just-published release tag), it just checks out that ref itself before this step runs, the same way every other job in this repository already does.
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/renovate/README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ jobs:
with:
message: "Renovate: updated on ${{ steps.renovate.outputs.target-name }} (${{ steps.renovate.outputs.updated-hosts }})"
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
telegram-chat-id: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
```

Not every target runs every requested app - `renovate.py` decides that itself, from the target manifest's own `apps` mapping, and simply does nothing (never opening an SSH connection) if none of the requested apps are present. To tell whether a host's image actually changed (rather than the pull being a no-op), it compares `docker compose images -q` output before and after the pull, and exposes that as this action's own `updated`/`updated-hosts`/`target-name` outputs.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,4 @@ jobs:
with:
message: "Deploy: ${{ matrix.name }} updated"
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
telegram-chat-id: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
7 changes: 4 additions & 3 deletions .github/workflows/notify-telegram-pr.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,8 @@ on:
workflow_dispatch:
jobs:
notify:
uses: rubykatzen/baseline/.github/workflows/notify-telegram-pr-shared.yml@v0.16.2
uses: rubykatzen/baseline/.github/workflows/notify-telegram-pr-shared.yml@v0.17.0
with:
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
secrets:
TELEGRAM_BOT_TOKEN: ${{ secrets.TELEGRAM_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
7 changes: 4 additions & 3 deletions .github/workflows/notify-telegram-release.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,8 @@ on:
types: [published]
jobs:
notify:
uses: rubykatzen/baseline/.github/workflows/notify-telegram-release-shared.yml@v0.16.2
uses: rubykatzen/baseline/.github/workflows/notify-telegram-release-shared.yml@v0.17.0
with:
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
secrets:
TELEGRAM_BOT_TOKEN: ${{ secrets.TELEGRAM_BOT_TOKEN }}
TELEGRAM_CHAT_ID: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/renovate.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,4 +41,4 @@ jobs:
with:
message: "Renovate: updated on ${{ steps.renovate.outputs.target-name }} (${{ steps.renovate.outputs.updated-hosts }})"
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
telegram-chat-id: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -366,7 +366,7 @@ jobs:
with:
message: "Deploy: mainframe updated"
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
telegram-chat-id: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
```

<!-- x-release-please-end -->
Expand DownExpand Up@@ -424,7 +424,7 @@ jobs:
with:
message: "Renovate: updated on ${{ steps.renovate.outputs.target-name }} (${{ steps.renovate.outputs.updated-hosts }})"
telegram-bot-token: ${{ secrets.TELEGRAM_BOT_TOKEN }}
telegram-chat-id: ${{ secrets.TELEGRAM_CHAT_ID }}
telegram-chat-id: ${{ vars.TELEGRAM_CHAT_ID }}
```

`renovate.yml` also runs on a nightly `schedule` (`0 3 * * *`), with `apps` defaulting to `[]` — a cron trigger can't supply `workflow_dispatch` inputs at all, so the empty-array-means-everything behavior above exists specifically to give the scheduled run something to pass.
Expand Down