Refactor discriminant lookup - #923
Merged
automergerpr-permission-manager[bot] merged 3 commits intoJan 30, 2026
Merged
Conversation
tothtamas28
approved these changes
Jan 30, 2026
automergerpr-permission-manager
Bot
deleted the
refactor-discriminant-lookup
branch
January 30, 2026 11:29
Closed
dkcumming
added a commit
that referenced
this pull request
Jan 31, 2026
automergerpr-permission-manager Bot
pushed a commit
to runtimeverification/solana-token
that referenced
this pull request
Feb 1, 2026
- runtimeverification/mir-semantics#918 - runtimeverification/mir-semantics#912 - runtimeverification/mir-semantics#919 - runtimeverification/mir-semantics#920 - runtimeverification/mir-semantics#923 - runtimeverification/mir-semantics#921 - runtimeverification/mir-semantics#922 - runtimeverification/mir-semantics#924
jberthold
added a commit
that referenced
this pull request
Feb 4, 2026
* reverts the rewrite counts in the golden files (by removing the rewrite symbol introduced in #923 * new helper functions to ensure definedness of discriminant/variantIdx lookup * Fixes p-token proofs (while still passing sync_native in SPL token)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The staged function evaluation created issues with the SMT solver (unevaluated terms could contain
#lookupDiscriminantcalls while the path condition held#lookupDiscrAuxconstraints).Making the first evaluation step a rewrite changes the step counters but avoids this problem altogether because rewrite symbols don't normally go to the SMT solver.