Improved show printing for leaves - #946
Merged
Merged
Conversation
This is so the span path for the failing nodes passes on CI
dkcumming
requested review from
Stevengre,
jberthold,
mariaKt,
palinatolmach and
tothtamas28
February 25, 2026 17:14
tothtamas28
approved these changes
Feb 25, 2026
This was referenced Mar 3, 2026
dkcumming
added a commit
to runtimeverification/solana-token
that referenced
this pull request
Mar 4, 2026
- More `BinOp::Offset` tests https://github.com/runtimeverification/mir-semantics/pull/#935 - fix: type of offset for applyBinOp(binOpOffset, ...) https://github.com/runtimeverification/mir-semantics/pull/#936 - Add type-correcting projections on pointer cast and related operations https://github.com/runtimeverification/mir-semantics/pull/#937 - Fix metadata on `PtrToPtr` cast https://github.com/runtimeverification/mir-semantics/pull/#941 - Corrections to Multisig cheatcodes https://github.com/runtimeverification/mir-semantics/pull/#942 - Handled additional Range constructor in `toSigners` side condition. https://github.com/runtimeverification/mir-semantics/pull/#944 - Update dependency: deps/stable-mir-json_release runtimeverification/mir-semantics#938 - Improved `show` printing for leaves runtimeverification/mir-semantics#946 - Fix/cachix pin no response runtimeverification/mir-semantics#950 - Hotfix/cachix pin checks runtimeverification/mir-semantics#951 - fix(rt): remove mutability guard on local variable assignment runtimeverification/mir-semantics#948 - Makefile `stable-mir-json` command to build release also runtimeverification/mir-semantics#963 - Add `rust-toolchain.toml` runtimeverification/mir-semantics#959 - Add cut-point rules for specific functions / intrinsics (via definition) runtimeverification/mir-semantics#960 - Update dependency: deps/stable-mir-json_release runtimeverification/mir-semantics#947 - Updated Solana cheatcodes with `Span` in `Call` `Terminator` (c17566dc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Version
This PR:
Spans through to#setUpCalleeDatainstead of being ignored from theTerminatorkmir show --leavesto print function, call site, and error messages when possible forpanicandassert_failedLong Version
In the event that a
panicorassert_failedis reached in a proof, a stuck leaf node will be present in the KCFG that calls** UNKNOWN FUNCTION **. It is not clear exactly which function is being called, where this is being called from, or what the error message is (if there is one) as all the information is represented as interned data (DefId,Span,AllocId).The print out of the failing nodes is improved for
kmir show --leavesfrom:to:
This is achieved by taking advantage of the deterministic location of the interned values, retrieving those values, and then consulting the
.smir.jsonto get the un-interned data associated with those interned values.