You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds a self-contained prove-rs reproducer for AccountState branch selection and discharges the symbolic discriminant guard by combining explicit AccountState domain constraints with a #lookupDiscrAux(... ) ==Int C normalization rule.
Context
After the multisig proof profile moved to 3 signers, the next live frontier in test_process_revoke_multisig sat on if account.state == AccountState::Frozen. The path constraint already chose a branch, but the <k> cell still carried #lookupDiscrAux(... variantIdx(?SplAccountState)) ==Int 2, so branch selection stayed pending on a syntactic mismatch.
Red vs Green
Red:
spl-accountstate-discriminant-branch.rs reaches the AccountState::Frozen check with a symbolic discriminant term.
The branch split constrains one side of the guard, but the guard itself remains in the unnormalized #lookupDiscrAux(...) ==Int 2 shape.
Green:
cheatcode_is_spl_account now states the explicit 3-variant AccountState discriminant domain.
#lookupDiscrAux(DISCRS, IDX) ==Int DISCR is normalized to DISCR ==Int #lookupDiscrAux(DISCRS, IDX), which matches the branch-constraint shape and lets #selectBlock discharge the guard.
Closing based on the validation above: the real test_process_revoke_multisig target now passes with the current proofs-side setup and mir-semantics PR #1007 branch, so this PR is no longer needed.
PR #978 looks unnecessary on the current baseline.
I validated the real target, test_process_revoke_multisig, in an isolated spl-token worktree using the current proofs-side setup together with the mir-semantics branch corresponding to PR #1007 (sync-pr1006, commit 1f3ff1d3). The proof passed cleanly with pending: 0, failing: 0, and stuck: 0.
That means the current proofs/spl-token + mir-semantics PR #1007 combination is already sufficient for this target, so PR #978 is not needed anymore. During the run I also did not observe the #lookupDiscrAux(... ) ==Int 2 stuck shape described in this PR, which suggests the reproducer here does not match the real proof path anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a self-contained
prove-rsreproducer forAccountStatebranch selection and discharges the symbolic discriminant guard by combining explicitAccountStatedomain constraints with a#lookupDiscrAux(... ) ==Int Cnormalization rule.Context
After the multisig proof profile moved to 3 signers, the next live frontier in
test_process_revoke_multisigsat onif account.state == AccountState::Frozen. The path constraint already chose a branch, but the<k>cell still carried#lookupDiscrAux(... variantIdx(?SplAccountState)) ==Int 2, so branch selection stayed pending on a syntactic mismatch.Red vs Green
Red:
spl-accountstate-discriminant-branch.rsreaches theAccountState::Frozencheck with a symbolic discriminant term.#lookupDiscrAux(...) ==Int 2shape.Green:
cheatcode_is_spl_accountnow states the explicit 3-variantAccountStatediscriminant domain.#lookupDiscrAux(DISCRS, IDX) ==Int DISCRis normalized toDISCR ==Int #lookupDiscrAux(DISCRS, IDX), which matches the branch-constraint shape and lets#selectBlockdischarge the guard.References
spl_token::state::AccountState