fix(specs): make shared MAX_SIGNERS checks type-safe - #176
Merged
Merged
Conversation
Stevengre
force-pushed
the
jh/fix-max-signers-kaas
branch
from
March 11, 2026 00:40
f0be61a to
bcb17a5
Compare
Stevengre
marked this pull request as draft
March 11, 2026 00:41
Stevengre
marked this pull request as ready for review
March 11, 2026 01:35
dkcumming
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the shared multisig initialize specs so they keep using
MAX_SIGNERSdirectly while type-checking in both inclusion contexts.The root issue was that the shared spec is included by both
spl-tokenandp-token, butMAX_SIGNERSdoes not have the same type in both paths. Replacing the old magic numbers withMAX_SIGNERStherefore introduced a type mismatch in the proof/runtime-verification path.Testing
cargo +nightly-2025-02-16 clippy --manifest-path p-token/Cargo.toml -Zunstable-options --all-targets --all-features -- --deny=warnings --deny=clippy::arithmetic_side_effectscargo +nightly-2025-02-16 check -p spl-token --features runtime-verificationFormat & Lint p-tokenpassed in run22931335543