Uh oh!
There was an error while loading. Please reload this page.
Replace error-chain with thiserror - #59
Merged
bors[bot] merged 4 commits intoSep 12, 2022
Merged
Conversation
matthiasbeyer
commented
Sep 12, 2022
MemberAuthor
Lets see what CI thinks. |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This patch replaces error-chain with the current version of thiserror. There's nothing done more, so no cleanup of .expect() or .unwrap() calls, just a plain conversion from one crate to another. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyerforce-pushed
the
error-chain-to-thiserror
branch
from
September 12, 2022 06:51
3feb056 to
0cddb83CompareSigned-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
commented
Sep 12, 2022
MemberAuthor
bors merge |
Contributor
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the abandoned
error-chaincrate withthiserror, but does not clean up anyexpect()orunwrap()calls!Closes#58