Uh oh!
There was an error while loading. Please reload this page.
Add cargo-test job - #67
Merged
Merged
Conversation
matthiasbeyer
commented
Sep 12, 2022
MemberAuthor
So that's what I have so far. The session-timeout tests are especially concerning, as I do not even see what the actual issue is. |
matthiasbeyer
commented
Sep 12, 2022
MemberAuthor
Funny enough: Locally, three tests fail: In CI, only one does. Strange! |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
If we emit a ReadUntil::NBytes, but the `eof` flag is already set and the buffer is indeed _not_ empty, we return Some() here. If the buffer is empty, there's nothing to return, so we return None. This fixes the following tests: * reader::tests::test_any_with_multiple_possible_matches * reader::tests::test_any_with_same_start_different_length * reader::tests::test_eof * reader::tests::test_expect_melon * reader::tests::test_nbytes * reader::tests::test_regex * reader::tests::test_regex2 Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyerforce-pushed
the
ci-test
branch
2 times, most recently
from
September 12, 2022 12:30
842e523 to
ce9e875CompareSigned-off-by: Gerd Zellweger <mail@gerdzellweger.com> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
commented
Sep 12, 2022
MemberAuthor
Contributor
Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a cargo-test job to CI.
DAMN. I forgot to add the
cargo-testjob in the initial CI. Lets see how I can make this crate run through tests...