Skip to content

Fix sporadic test failure - #75

Merged
bors[bot] merged 1 commit into
rust-cli:masterfrom
matthiasbeyer:fix-sporadic-test
Oct 9, 2022
Merged

Fix sporadic test failure#75
bors[bot] merged 1 commit into
rust-cli:masterfrom
matthiasbeyer:fix-sporadic-test

Conversation

@matthiasbeyer

@matthiasbeyermatthiasbeyer commented Oct 9, 2022

Copy link
Copy Markdown
Member
DetailsCloses#70

@matthiasbeyer
Increase timeout for slow github-action machines
350671f
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyermatthiasbeyer mentioned this pull request Oct 9, 2022
Closed
@matthiasbeyer

matthiasbeyer commented Oct 9, 2022

Copy link
Copy Markdown
MemberAuthor

So that made it work for now. @petreeftime what do you think? Is that enough? Or just a "sporadic success"? 😆

@matthiasbeyer
matthiasbeyer marked this pull request as ready for review October 9, 2022 08:26
@matthiasbeyer

matthiasbeyer commented Oct 9, 2022

Copy link
Copy Markdown
MemberAuthor

I guess I can

bors try

to see whether this does the trick or fails again...

borsBot added a commit that referenced this pull request Oct 9, 2022
@bors
Try#75:
553c781
@bors

borsBot commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

try

Build succeeded:

@petreeftime

petreeftime commented Oct 9, 2022

Copy link
Copy Markdown
Collaborator

The error seems to be caused by duplication of output, so I don't know whether this will help. I don't see a reason not to try, but I think there must be something that either was always buggy and interacts poorly with the test env, or caused by some minor change in nix 0.25 vs 0.14 that interacts poorly with the test env.

@petreeftime

petreeftime commented Oct 9, 2022

Copy link
Copy Markdown
Collaborator

bors merge

@matthiasbeyer

matthiasbeyer commented Oct 9, 2022

Copy link
Copy Markdown
MemberAuthor

What I can think of is that the timeout is too short, and that caused the test to execute the following:

cat hanshans: no such command

or something like that (because cat gets stopped too soon). I don't know for sure, of course, but that's the first thing I could think of.

@matthiasbeyer

matthiasbeyer commented Oct 9, 2022

Copy link
Copy Markdown
MemberAuthor

Why does this take so long? Is bors overloaded right now? Weird... 🤔

@bors

borsBot commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
borsBot merged commit 2151dab into rust-cli:masterOct 9, 2022
@matthiasbeyer
matthiasbeyer deleted the fix-sporadic-test branch October 9, 2022 10:19
@matthiasbeyermatthiasbeyer mentioned this pull request Aug 17, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petreeftimepetreeftimepetreeftime approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_read_line fails randomly

2 participants

@matthiasbeyer@petreeftime