Skip to content

Fix broken link to std::process::Command - #271

Merged
bors[bot] merged 1 commit into
rust-embedded:masterfrom
jyn514:broken-links
Oct 15, 2020
Merged

Fix broken link to std::process::Command#271
bors[bot] merged 1 commit into
rust-embedded:masterfrom
jyn514:broken-links

Conversation

@jyn514

@jyn514jyn514 commented Oct 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Intra-doc links do not yet work in markdown files; see rust-lang/rust#77974.

Part of rust-lang/rust#77971.

@jyn514
Fix broken link to std::process::Command
70de9a2
Intra-doc links do not yet work in markdown files; see
rust-lang/rust#77974.
@jyn514
jyn514 requested a review from a team as a code ownerOctober 15, 2020 14:00
@rust-highfive

rust-highfive commented Oct 15, 2020

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Oct 15, 2020
@jyn514

jyn514 commented Oct 15, 2020

Copy link
Copy Markdown
ContributorAuthor

You can see the currently broken link at https://docs.rust-embedded.org/book/interoperability/c-with-rust.html#triggering-external-build-systems.

@jyn514jyn514 mentioned this pull request Oct 15, 2020
Merged
therealprof
therealprof approved these changes Oct 15, 2020
View reviewed changes

@therealproftherealprof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

bors r+

@bors

borsBot commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
borsBot merged commit ca8169e into rust-embedded:masterOct 15, 2020
@jyn514
jyn514 deleted the broken-links branch October 15, 2020 15:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therealproftherealproftherealprof approved these changes

Assignees

@adamgreigadamgreig

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-resources

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jyn514@rust-highfive@therealprof@adamgreig