Skip to content

Add features for queues. - #565

Open
reitermarkus wants to merge 1 commit into
rust-embedded:mainfrom
reitermarkus:queue-features
Open

Add features for queues.#565
reitermarkus wants to merge 1 commit into
rust-embedded:mainfrom
reitermarkus:queue-features

Conversation

@reitermarkus

Copy link
Copy Markdown
Member

Partially addresses #372.

@reitermarkus
reitermarkus requested a review from a teamApril 27, 2025 22:13
@Dirbaio

Copy link
Copy Markdown
Member

Have you measured how much compile time this saves?

IMO features make sense if they prevent pulling in big dependencies, but in this case they just prevent compiling a few hundred lines of code. In this case the compile time difference is probably negligible, and not worth the dev-experience downgrade due to users having to enable features.

@reitermarkus

Copy link
Copy Markdown
MemberAuthor

No, I didn't measure compile time.

Should we just close #372 then? The only non-optional dependency we have is hash32, which is pretty tiny as well, with no dependencies itself.

@sguedsgued added the API Break Breaking changes label Apr 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API BreakBreaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@reitermarkus@Dirbaio@sgued