Uh oh!
There was an error while loading. Please reload this page.
fix TOML in Cargo.toml - #91
Conversation
per https://toml.io/en/v1.0.0#inline-table, `No newlines are allowed between the curly braces unless they are valid within a value`. Partially fixesrust-in-action#77 (there's also the "unresolved import `smoltcp::phy::TapInterface`" issue).
ewenmcneill
commented
Jan 10, 2023
dmitris
commented
Jan 11, 2023
the question is what needs to happen to get this PR merged 😄 @timClicks - are you still looking at this repo? |
timClicks
commented
Jan 11, 2023
via email
Yes I am! Sorry that I'm not very active.
I don't accept any PRs for copyright reasons. …On Thu, 12 Jan 2023 at 09:53, Dmitry Savintsev ***@***.***> wrote:
the question is what needs to happen to get this PR merged 😄
@timClicks <https://github.com/timClicks> - are you still looking at this
repo?
—
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGZ4IWCJ3UDQ3WUJXZYXDWR4MVDANCNFSM6AAAAAAR5R2SSM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ewenmcneill
commented
Jan 12, 2023
@timClicks Perhaps you could at least put a note (near the top) of the README file that says "sorry I don't accept PRs for copyright reasons". Because there are ~18 months of PRs (including several duplicates) that people have created, trying to help, because they didn't know you weren't going to accept them. (Inexplicably GitHub still doesn't allow disabling PRs in a repo while leaving issues enabled :-( ) Ewen |
timClicks
commented
Jan 14, 2023
I understand the frustration. I'll look into adding a note on the README. Leaving the PRs open was intended to make it less likely that there will be duplicate effort. |
per https://toml.io/en/v1.0.0#inline-table,
No newlines are allowed between the curly braces unless they are valid within a value.Fixes#77.