[WIP] feat(manifest): add a force-frame-pointers profile option - #15451
[WIP] feat(manifest): add a force-frame-pointers profile option#15451brvtalcake wants to merge 1 commit into
force-frame-pointers profile option#15451Conversation
There was a problem hiding this comment.
Some of the solution details are still being discussed in #15451
| #[cargo_test] | ||
| fn force_frame_pointers_on_works() { |
There was a problem hiding this comment.
Would you be up for putting the tests in a previous commit without force-frame-pointers, having them pass, showing the existing behavior? Then in this commit, the diff highlights the new feature and what it changes
There was a problem hiding this comment.
No problem, I can do that
There was a problem hiding this comment.
EDIT : I suppose I should first wait for a conclusion to the conversation in the related issue ?
force-frame-pointers profile optionforce-frame-pointers profile option
|
☔ The latest upstream changes (possibly #15841) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I am going to close this PR as its stale and there have been other developments in the issue. including merging #16742 which appears to do the same thing as this PR I believe the latest update is: #15333 (comment) |
What does this PR try to resolve?
This PR resolves #15333, and a
force-frame-pointersoption for profiles. It also fixes tests related to profiles, and adds some basic tests for the new option itself.How should we test and review this PR?
Run the tests in
tests/testsuite/profiles.rs:force_frame_pointers_on_worksforce_frame_pointers_off_worksforce_frame_pointers_unspecified_worksAdditional information
See, however, the discussion in the linked issue, as there might be some changes needed