Uh oh!
There was an error while loading. Please reload this page.
Fix bug in CMSG_NXTHDR for android. - #1976
Closed
LinkTed wants to merge 1 commit into
Closed
Conversation
…L if it is the last control message in the chain.
rust-highfive
commented
Nov 15, 2020
r? @JohnTitor (rust_highfive has picked a reviewer for you, use r? to override) |
JohnTitor
commented
Nov 23, 2020
Member
@bors r+ |
bors
commented
Nov 23, 2020
Contributor
📌 Commit 724d1a3 has been approved by |
bors
commented
Nov 23, 2020
Contributor
bors added a commit
that referenced
this pull request
Nov 23, 2020
Fix bug in `CMSG_NXTHDR` for android. `CMSG_NXTHDR` should return NULL if it is the last control message in the chain.
bors
commented
Nov 23, 2020
Contributor
💔 Test failed - checks-actions |
LinkTed
commented
Nov 23, 2020
ContributorAuthor
It seems that the android implementation (bionic) is wrong. Should I close the PR? |
JohnTitor
commented
Nov 24, 2020
Member
Hm, if it's wrong and/or we don't need a fix for rust-lang/rust#69864, then yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMSG_NXTHDRshould return NULL if it is the last control message in the chain.