Uh oh!
There was an error while loading. Please reload this page.
Added extensive constants to make use of the BSD's sysctl function. - #285
Conversation
rust-highfive
commented
May 11, 2016
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
May 11, 2016
Thanks! Looks like some of the CI failures are legitimate though? |
raphaelcohn
commented
May 11, 2016
OK will take a look in the morning...
|
raphaelcohn
commented
May 12, 2016
OK, looks like I missed some duplicate definitions which had been added piecemeal. I'm beginning to wonder, even though it creates apparent duplication, whether it would be better to drop the attempt to create a hierarchy of unices and just push all definitions down to a per-OS file. It could make maintenance easier. Thoughts? Alternatively, a kickstarter campaign to flesh out all remaining libc bits and bobs... I'd be game for that. |
alexcrichton
commented
May 12, 2016
Heh, yeah the organization as-is may be a bit of an opportunistic optimization that may not be worth it in the end, but we probably don't want to shift it all around just yet. |
raphaelcohn
commented
May 12, 2016
Fair enough
|
alexcrichton
commented
May 12, 2016
Looks like travis is still having some problems though? |
raphaelcohn
commented
May 13, 2016
OK, I think I've fixed this. (I must say, I'm dead impressed with your CI builds. They're very effective). |
raphaelcohn
commented
May 13, 2016
OK, looks like we're just down to bitrig failing now...I'll try again... |
sysctl usage does differ significantly across the BSDs, and, whilst some constants overlap, many do not. It is easier to maintain them in separate modules, rather than trying to tease out common definitions.
alexcrichton
commented
May 13, 2016
bors
commented
May 14, 2016
Added extensive constants to make use of the BSD's sysctl function. sysctl usage does differ significantly across the BSDs, and, whilst some constants overlap, many do not. It is easier to maintain them in separate modules, rather than trying to tease out common definitions.
bors
commented
May 14, 2016
☀️ Test successful - status-appveyor, travis |
Nercury
commented
May 15, 2016
@raphaelcohn It looks like |
Removed by accident in rust-lang#285
Add back HW_NCPU Removed by accident in #285
alexcrichton
commented
May 16, 2016
Ah yeah that's accidentally, I'm adding it back in #291 |
Use libc constants in sys/signal.rs. Work toward rust-lang#264.
sysctl usage does differ significantly across the BSDs, and, whilst
some constants overlap, many do not. It is easier to maintain them
in separate modules, rather than trying to tease out common definitions.