Skip to content

Linux: epoll: add busy polling parameters - #3922

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
tammela:busypoll-ioctl
Nov 6, 2024
Merged

Linux: epoll: add busy polling parameters#3922
tgross35 merged 1 commit into
rust-lang:mainfrom
tammela:busypoll-ioctl

Conversation

@tammela

Copy link
Copy Markdown
Contributor

In Linux 6.9 a new ioctl for epoll was added:
https://man.archlinux.org/man/ioctl_eventpoll.2.en

It's used for busy polling sockets

@rustbot

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tammela
tammela marked this pull request as ready for review September 16, 2024 12:54
Comment threadsrc/unix/linux_like/linux/mod.rs
@tgross35

tgross35 commented Oct 1, 2024

Copy link
Copy Markdown
Member

Could you please update the relevant files in libc-test/semver? Also, why src/unix/linux_like/linux/arch/generic/mod.rs, can't this just go in src/unix/linux/mod.rs?

@tammela

tammela commented Oct 10, 2024

Copy link
Copy Markdown
ContributorAuthor

Could you please update the relevant files in libc-test/semver?

Will do

Also, why src/unix/linux_like/linux/arch/generic/mod.rs, can't this just go in src/unix/linux/mod.rs?

No preference really. As long as it only exposed to Linux builds, it's fine.
My rationale was that since it's an ioctl parameter, it should be close to the ioctl constants

@tammela
tammelaforce-pushed the busypoll-ioctl branch 2 times, most recently from 810aa44 to 465a935CompareOctober 10, 2024 17:24
In Linux 6.9 a new ioctl for epoll was added:
https://man.archlinux.org/man/ioctl_eventpoll.2.en
Add support for it. The ioctls constants are padded to
64 bits alignment even on 32 bits machines.
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
@tgross35tgross35 changed the title epoll: add busy polling parametersLinux: epoll: add busy polling parametersNov 6, 2024
@tgross35
tgross35 enabled auto-merge November 6, 2024 19:38
@tgross35tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 6, 2024
@tgross35
tgross35 added this pull request to the merge queueNov 6, 2024
Merged via the queue into rust-lang:main with commit 5d5c51bNov 6, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 7, 2024
In Linux 6.9 a new ioctl for epoll was added:
https://man.archlinux.org/man/ioctl_eventpoll.2.en
Add support for it. The ioctls constants are padded to
64 bits alignment even on 32 bits machines.
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
(backport <rust-lang#3922>)
(cherry picked from commit fb58c01)
Signed-off-by: Trevor Gross <tmgross@umich.edu>
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 7, 2024
In Linux 6.9 a new ioctl for epoll was added:
https://man.archlinux.org/man/ioctl_eventpoll.2.en
Add support for it. The ioctls constants are padded to
64 bits alignment even on 32 bits machines.
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
(backport <rust-lang#3922>)
(cherry picked from commit fb58c01)
Signed-off-by: Trevor Gross <tmgross@umich.edu>
@tgross35tgross35 mentioned this pull request Nov 7, 2024
@tgross35tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 7, 2024
AkhilTThomas pushed a commit to AkhilTThomas/libc that referenced this pull request Feb 5, 2025
In Linux 6.9 a new ioctl for epoll was added:
https://man.archlinux.org/man/ioctl_eventpoll.2.en
Add support for it. The ioctls constants are padded to
64 bits alignment even on 32 bits machines.
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
(backport <rust-lang#3922>)
(cherry picked from commit fb58c01)
Signed-off-by: Trevor Gross <tmgross@umich.edu>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewstable-appliedThis PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tammela@rustbot@tgross35@JohnTitor