Skip to content

try moving pipe2 from notbsd to unix - #501

Closed
oconnor663 wants to merge 1 commit into
rust-lang:masterfrom
oconnor663:pipe2
Closed

try moving pipe2 from notbsd to unix#501
oconnor663 wants to merge 1 commit into
rust-lang:masterfrom
oconnor663:pipe2

Conversation

@oconnor663

@oconnor663oconnor663 commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

#500

This is mostly to see what breaks in CI.

@rust-highfive

rust-highfive commented Jan 25, 2017

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@oconnor663

oconnor663 commented Jan 25, 2017

Copy link
Copy Markdown
ContributorAuthor

Ok yeah, this breaks on OSX.

@oconnor663

oconnor663 commented Jan 25, 2017

Copy link
Copy Markdown
ContributorAuthor

Here's the failing build: https://travis-ci.org/rust-lang/libc/builds/195223765

oconnor663 added a commit to oconnor663/libc that referenced this pull request Jan 25, 2017
@oconnor663
add pipe2 to non-OSX BSD's
7c06730
rust-lang#501
@oconnor663oconnor663 mentioned this pull request Jan 25, 2017
Merged
@oconnor663
oconnor663 deleted the pipe2 branch February 1, 2017 20:31
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
@homu
Auto merge ofrust-lang#503- Idolf:bitflags, r=kamalmarhubi
2bb718c
Fix the style for bitflags!
Prefer `libc_bitflags!` over `bitflags!`. Prefer `libc::CONSTANTS` over
writing the constant manually.
This makes rust-lang#501 unnecessary, since upstream now contains the `O_TMPFILE` constant.
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
@gnzlbg
[s390x] Fall back to scalar math for portable floating-point vector o…
60826e7
…perations.
I've opened rust-lang#501 to track the workarounds introduced here.
Closesrust-lang#498.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oconnor663@rust-highfive@alexcrichton