Skip to content

Document RFC 1940 (must_use on fns) - #247

Merged
alercah merged 4 commits into
rust-lang:masterfrom
Havvy:must-use
May 3, 2018
Merged

Document RFC 1940 (must_use on fns)#247
alercah merged 4 commits into
rust-lang:masterfrom
Havvy:must-use

Conversation

@Havvy

@HavvyHavvy commented Feb 19, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

This is the reference side of documenting this attribute — both the updates for the RFC and the original functionality. I do not think that this PR is sufficient documentation for stabilizing the feature, as I think the API guidelines should also be updated.

alercah
alercah approved these changes Feb 20, 2018
View reviewed changes
Comment threadsrc/attributes.md Outdated
}
```

#### Must Use Attribute

@alercahalercahFeb 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change this to "must_use Attribute"

Comment threadsrc/attributes.md Outdated
# impl MustUse {
# fn new() -> MustUse { MustUse {} }
# }

@alercahalercahFeb 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a # to the start of one of these blank lines to avoid two in the rendered text.

@HavvyHavvy added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Feb 20, 2018
@zackmdaviszackmdavis mentioned this pull request Feb 23, 2018
Closed
@zackmdaviszackmdavis mentioned this pull request Mar 18, 2018
Closed
3 tasks
@Havvy

Havvy commented Apr 3, 2018

Copy link
Copy Markdown
ContributorAuthor

Updated for behaviour with trait objects.

Travis failure is in building mdbook?

@steveklabnik

steveklabnik commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Travis failure is in building mdbook?

That's... odd

@zackmdavis

zackmdavis commented May 2, 2018

Copy link
Copy Markdown

Stabilization PR has landed.

@Havvy

Havvy commented May 3, 2018

Copy link
Copy Markdown
ContributorAuthor

I added a commit that just added a space and then had Travis test it. It passed. I then deleted that commit and it went back to the previous status of not passing because of whatever mysterious error we had last time. So if anybody wants to merge this, it's ready for merging.

@zackmdavis

zackmdavis commented May 3, 2018

Copy link
Copy Markdown

Travis will probably rebuild if you rebase on master?

@Havvy

Havvy commented May 3, 2018

Copy link
Copy Markdown
ContributorAuthor

You are correct, and it now shows as passing.

@alercah
alercah merged commit b6d4ed7 into rust-lang:masterMay 3, 2018
@Havvy
Havvy deleted the must-use branch May 3, 2018 20:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alercahalercahalercah approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-stabilizationWaiting for a stabilization PR to be merged in the main Rust repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Havvy@steveklabnik@zackmdavis@alercah