Skip to content

Fix tidy on Windows - #36

Merged
steveklabnik merged 1 commit into
rust-lang:masterfrom
petrochenkov:master
Apr 6, 2017
Merged

Fix tidy on Windows#36
steveklabnik merged 1 commit into
rust-lang:masterfrom
petrochenkov:master

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

This is exactly the same issue as rust-lang/book#549, x.py test src/tools/tidy is failing again.
r? @steveklabnik@carols10cents

@carols10centscarols10cents left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have r here, but lgtm!

@steveklabnik
steveklabnik merged commit 3a64d81 into rust-lang:masterApr 6, 2017
@steveklabnik

Copy link
Copy Markdown
Contributor

Thanks!

@steveklabnik

Copy link
Copy Markdown
Contributor

x.py test src/tools/tidy is failing again.

incidentally, how did you notice this? Did you try to update the submodule yourself?

@petrochenkov

Copy link
Copy Markdown
ContributorAuthor

@steveklabnik
Default git settings on Windows is "checkout as \r\n, commit as \n", so this issue reproduced automatically when I updated the Rust repo and run tidy.
This can be solved by adding .gitattributes to the repo once, or changing settings to "checkout as \n" by all people testing Rust on Windows. Adding .gitattributes seems nicer and the main repo did this, but every time someone creates a new submodule and forgets to add .gitattributes the problem repeats.

mark-i-m pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Dec 1, 2018
borsBot added a commit to rust-embedded/book that referenced this pull request Feb 10, 2019
127: Fix failing tidy (line endings on Windows) r=japaric a=petrochenkov
This happens every time a new doc submodule is added to https://github.com/rust-lang/rust.
cc rust-lang/book#549rust-lang/reference#36rust-lang/rust-by-example#1018rust-lang/rustc-dev-guide#246
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@petrochenkov@steveklabnik@carols10cents