Skip to content

Test attributes deserve their own section - #382

Merged
matthewjasper merged 3 commits into
rust-lang:masterfrom
Havvy:test-attr
Sep 1, 2018
Merged

Test attributes deserve their own section#382
matthewjasper merged 3 commits into
rust-lang:masterfrom
Havvy:test-attr

Conversation

@Havvy

@HavvyHavvy commented Aug 1, 2018

Copy link
Copy Markdown
Contributor

cc @QuietMisdreavus and @steveklabnik for possibly out-of-scope documentation here.

@Havvy

Havvy commented Aug 1, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Do not merge both this and the previous PR at the same time until I've edited the other PR to remove the "function-only attributes" section since the two PRs remove all of the attributes from that section.

@HavvyHavvy mentioned this pull request Aug 3, 2018
Merged
steveklabnik
steveklabnik approved these changes Aug 18, 2018
View reviewed changes

@steveklabniksteveklabnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Havvy

Havvy commented Aug 19, 2018

Copy link
Copy Markdown
ContributorAuthor

With the other PR merged, this one now also handles removing the entirety of the "Function only items" section and can be merged.

Hmm, I probably should have done that in a new commit, but it's 2am and I'm not thinking straight. But wanted to get this unblocked before I head to bed. Sorry. The only change since the previous comment is just the removal of that header.

@HavvyHavvy added the New Content Missing features or aspects of language not currently documented. label Aug 20, 2018
matthewjasper
matthewjasper approved these changes Sep 1, 2018
View reviewed changes

@matthewjaspermatthewjasper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, then this is good to merge.

Comment threadsrc/attributes.md Outdated
> Note: The test harness is ran by passing the `--test` argument to `rustc` or
> using `cargo test`.

Tests that return `()` pass as long as they terminate do not panic. Tests that

@matthewjaspermatthewjasperSep 1, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing 'and' after 'terminate'

@HavvyHavvySep 1, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@matthewjasper
matthewjasper merged commit 65e9b3d into rust-lang:masterSep 1, 2018
@matthewjasper

matthewjasper commented Sep 1, 2018

Copy link
Copy Markdown
Contributor

Thanks!

@Havvy
Havvy deleted the test-attr branch September 1, 2018 20:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@steveklabniksteveklabniksteveklabnik approved these changes
@matthewjaspermatthewjaspermatthewjasper approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

New ContentMissing features or aspects of language not currently documented.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Havvy@matthewjasper@steveklabnik