Uh oh!
There was an error while loading. Please reload this page.
Upgrades for mdbook 0.2.0, and link style cleanup. - #391
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Havvy
commented
Aug 9, 2018
Oh, I commented on commits as I checked on each commit. Thus some stuff says out of date even though it's not. |
Havvy
commented
Sep 20, 2018
This needs to be rebased pretty badly. I think it'd be easier if the alphabetizing commit was its own PR. |
alercah
commented
Jan 27, 2019
Rebased and updated, removed the sorting/organization and just stuck on the version upgrade. |
alercah
commented
Jan 27, 2019
ehuss
commented
Jan 28, 2019
These links don't look correct to me. They should all be relative to the page they are on. For example, There also looks to be some unintended changes to |
ehuss
commented
Jan 28, 2019
Oh, |
steveklabnik
commented
Jan 28, 2019
I'm running linkcheck on this right now, but I suspect @ehuss is correct. |
steveklabnik
commented
Jan 28, 2019
Oh shucks, it looks like the upstream PR for multi-mdbook support has not actually landed. I thought it had. Let me take care of that ASAP. |
steveklabnik
commented
Jan 28, 2019
Now r+'d rust-lang/rust#57495 |
alercah
commented
Jan 29, 2019
@ehuss Ah right, I thought I reverted all the ones outside of subdirs since I did them by mistake, but missed |
ehuss
left a comment
There was a problem hiding this comment.
All of the links to .html in-repo need to be updated to .md. This allows links to work on GitHub, and mdbook doesn't handle the .html links properly in the print page (all links not in the root are currently broken on the print page).
Uh oh!
There was an error while loading. Please reload this page.
| install: | ||
| - travis_retry curl -Lf https://github.com/rust-lang-nursery/mdBook/releases/download/v0.1.7/mdbook-v0.1.7-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=$HOME/.cargo/bin | ||
| - travis_retry curl -Lf https://github.com/rust-lang-nursery/mdBook/releases/download/v0.2.1/mdbook-v0.2.1-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=$HOME/.cargo/bin |
There was a problem hiding this comment.
Oh, hmm, this needs to be 0.2.3. @steveklabnik would it be possible to publish a binary for the latest release on github?
So, I have good news, and I have bad news. Good news is, I ran this against upstream's linkchecker. Bad news is that I got: ... and more, but I won't paste the same line about print.html over and over again... I am very confused about |
steveklabnik
commented
Jan 29, 2019
ahhhhhh yes |
steveklabnik
commented
Jan 30, 2019
The upstream PR has landed! @alercah let me know when you want me to try the linkchecker again :) |
mdbook 0.2.0 says that src/theme was accepted in error.
alercah
commented
Feb 2, 2019
Apologies for the delay here, had some issues. Should be good to go now, though I can't get linkcheck to ignore the parent directories so I can't be totally sure. |
ehuss
commented
Feb 2, 2019
Hm, something's wrong. I swore I tested the print page on 0.2.3, but there are still problems. There are two issues:
I'll see if I can figure out what's wrong in the next few days. |
ehuss
commented
Feb 3, 2019
I have posted a proposed fix for the print.html links at rust-lang/mdBook#871. As for publishing 0.2.3, it looks like the deploy scripts are broken (travis and appveyor). I have posted a partial fix for Travis at rust-lang/mdBook#872. The API keys need to be fixed since the transition to travis.com. @steveklabnik if you have permissions, can you take care of that? Or if not, I can try to bug infra and get things worked out. Alternatively the releases can be made manually (it's just a compressed copy of the mdbook executable), and uploaded manually on the GitHub releases page. |
mati865
commented
Jul 7, 2019
There is mdbook 0.3 so this should be unblocked but there are so many conflicts and new links this PR probably has to be redone from scratch. |
ehuss
commented
Jul 7, 2019
@mati865 There was another bug blocking the update of the reference and cargo (rust-lang/mdBook#963). It is now fixed, I just need to make a new release. I'll be posting a new PR here to replace this one when things are ready. It will require a coordinated update due to some changes to anchor tags. I think I'll be able to eradicate 0.1 during that update. |
See individual commit messages for description of what I did.
I have not verified all links.
mdbook-linkcheckdoes not yet support 0.2.0.