Skip to content

Grammar: types - #433

Merged
matthewjasper merged 3 commits into
rust-lang:masterfrom
ehuss:grammar-types
Oct 6, 2018
Merged

Grammar: types#433
matthewjasper merged 3 commits into
rust-lang:masterfrom
ehuss:grammar-types

Conversation

@ehuss

Copy link
Copy Markdown
Contributor

No description provided.

@ehuss

ehuss commented Sep 25, 2018

Copy link
Copy Markdown
ContributorAuthor

One rule (FunctionParametersMaybeNamedVariadic) is blocked on #430. EDIT: Updated.

I was thinking it might be a good idea to split the types chapter into multiple subchapters. If you want, I can do that after this is done.

@matthewjaspermatthewjasper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I don't think that Type and TypeNoBounds are quite correct, everything else looks good.

Comment threadsrc/types.md Outdated
> _TupleType_ :\
>       `(` `)`\
>    | `(` [_Type_] `,` `)`\
> &nbsp;&nbsp; | `(` [_Type_]&nbsp;( `,` [_Type_] ) <sup>+</sup> `,`<sup>?</sup> `)`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two could be combined as ( ( Type, ) +Type?)

Comment threadsrc/types.md Outdated
Comment threadsrc/types.md
Comment threadsrc/types.md Outdated
<!--
What else should be said here?
The only documentation I am aware of is https://rust-lang-nursery.github.io/rustc-guide/type-inference.html
Should there be a broader discussion of type inference somewhere?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eventually.

@matthewjasper

Copy link
Copy Markdown
Contributor

Thanks again!

@matthewjasper
matthewjasper merged commit 6a5a823 into rust-lang:masterOct 6, 2018
@ehussehuss mentioned this pull request Oct 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ehuss@matthewjasper