Uh oh!
There was an error while loading. Please reload this page.
Referenceify conditional compilation - #444
Merged
Merged
Conversation
ehuss
reviewed
Oct 9, 2018
| Example values: | ||
| * `"x86"`, |
Contributor
There was a problem hiding this comment.
There are some random trailing commas here.
ehuss
reviewed
Oct 9, 2018
| > [IDENTIFIER] (`=` ([STRING_LITERAL] | [RAW_STRING_LITERAL]))<sup>?</sup> | ||
| > | ||
| > _ConfigurationAll_\ | ||
| > `all` `(` _ConfigurationPredicate_ (`,` _ConfigurationPredicate_)<sup>\*</sup> `,`<sup>?</sup> `)` |
Contributor
There was a problem hiding this comment.
These don't seem to capture that they can be an empty list. Not sure if that is important, since that is an odd usage.
ehuss
reviewed
Oct 11, 2018
ehuss
left a comment
Contributor
There was a problem hiding this comment.
I don't have any significant comments. Maybe move the Forms section before the option list, because you have to scroll all the way to the bottom to see any examples. But that's not critical, either way is fine.
| > **Note**: The `cfg_attr` can expand to another `cfg_attr`. For example, | ||
| > `#[cfg_attr(linux, cfg_attr(feature = "multithreaded", some_other_attribute))` | ||
| > is valid. This example would be equivalent to | ||
| > `#[cfg_attr(and(linux, feaure ="multithreaded"), some_other_attribute)]`. |
Havvy
commented
Oct 17, 2018
ContributorAuthor
I don't like having them all the way on the bottom either, and the page is describing things in a bottom-up way. Perhaps we should invert it, and explain the attributes and macro first? |
matthewjasper
approved these changes
Oct 23, 2018
| for targets with 32-bit pointers, this is set to `"32"`. Likewise, it is set | ||
| to `"64"` for targets with 64-bit pointers. | ||
| <!-- Are there targets that have a different bit number? --> |
matthewjasper
commented
Nov 18, 2018
Contributor
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Fixes#384
Partial r? @ehuss for grammar additions.
I put a couple questions into comments into the source itself.
I also wonder if making each configuration option set by the compiler its own section like I did is too spacey. I could bring it back down into a list if y'all agree with that.