Uh oh!
There was an error while loading. Please reload this page.
extern crate changes. - #455
Merged
Merged
Conversation
| Possible upcoming changes that will change this: | ||
| `extern crate` items will automatically be added to the extern prelude. | ||
| https://github.com/rust-lang/rust/pull/54658 |
ContributorAuthor
There was a problem hiding this comment.
The changes are behind the extern_crate_item_prelude feature flag, so there's not much difference. I don't know what the future holds, there are no tracking issues. I tweaked the wording slightly, but it still seems a little awkward to me. Is the distinction between the --extern added to extern prelude and extern crate being placed as an item in the current scope clear enough? Should it emphasize this distinction more?
matthewjasper
approved these changes
Oct 31, 2018
matthewjasper
left a comment
Contributor
There was a problem hiding this comment.
I'm happy to merge this once the conflict is resolved
ehuss
commented
Nov 1, 2018
ContributorAuthor
Oops, I'm so used to bors leaving a message I forget to check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilization PR: rust-lang/rust#54403