Skip to content

Update conditional-compilation.md - #502

Merged
Havvy merged 1 commit into
rust-lang:masterfrom
jethrogb:patch-1
Jan 9, 2019
Merged

Update conditional-compilation.md#502
Havvy merged 1 commit into
rust-lang:masterfrom
jethrogb:patch-1

Conversation

@jethrogb

Copy link
Copy Markdown
Contributor

No description provided.

@CentrilCentril added S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository RFC Stabilization Docs Documentation required for stabilizing a feature labels Jan 9, 2019
@nagisa

Copy link
Copy Markdown
Member

IMHO you could just replace "possible values" with "Example values" to match the other target cfgs. This is the more appropriate way to do it either way.

@nagisa

Copy link
Copy Markdown
Member

Erhm, I wrote that comment above before double-checking the PR. It seems you did exactly that!

@HavvyHavvy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@Havvy
Havvy merged commit 5865673 into rust-lang:masterJan 9, 2019
jethrogb added a commit to jethrogb/reference that referenced this pull request Jan 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFC Stabilization DocsDocumentation required for stabilizing a featureS-waiting-on-stabilizationWaiting for a stabilization PR to be merged in the main Rust repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jethrogb@nagisa@Havvy@Centril