Skip to content

Modify RFC #803 (type ascription) to make type ascription expressions lvalues - #987

Merged
nikomatsakis merged 3 commits into
rust-lang:masterfrom
nrc:ascription-2
Jun 10, 2015
Merged

Modify RFC #803 (type ascription) to make type ascription expressions lvalues#987
nikomatsakis merged 3 commits into
rust-lang:masterfrom
nrc:ascription-2

Conversation

@nrc

@nrcnrc commented Mar 18, 2015

Copy link
Copy Markdown
Member

No description provided.

@nrc

nrc commented Mar 18, 2015

Copy link
Copy Markdown
MemberAuthor

cc @eddyb@nikomatsakis

@huonw

huonw commented Mar 18, 2015

Copy link
Copy Markdown
Contributor

The history seems strange?

@nrc

nrc commented Mar 18, 2015

Copy link
Copy Markdown
MemberAuthor

Yeah, I screwed the history up some how, I'll try to fix it at some point

@nrcnrc self-assigned this Mar 18, 2015
@nrc

nrc commented Mar 23, 2015

Copy link
Copy Markdown
MemberAuthor

Fixed the history and addressed @pnkfelix's comment

@nrcnrc mentioned this pull request Mar 27, 2015
Closed
@Ericson2314

Ericson2314 commented Apr 6, 2015

Copy link
Copy Markdown
Contributor

+1 definitely an improvement. Would be nice if for the assignment case (<expr> = ...;), casting to a subtype was eventually supported.

@nrcnrc added the T-lang Relevant to the language team, which will review and decide on the RFC. label May 15, 2015
@nikomatsakis

nikomatsakis commented Jun 3, 2015

Copy link
Copy Markdown
Contributor

Hear ye, hear ye. This RFC is entering the final comment period.

@nikomatsakisnikomatsakis added the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Jun 3, 2015
@huonw

huonw commented Jun 3, 2015

Copy link
Copy Markdown
Contributor

Just to clarify, this would allow writing the following?

let x;
x: i32 = 10;

nikomatsakis
nikomatsakis reviewed Jun 9, 2015
View reviewed changes
Comment threadtext/0803-type-ascription.md Outdated

@nikomatsakisnikomatsakisJun 9, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This <expr> renders funny. You should add verbatim quotes.

@nrc

nrc commented Jun 10, 2015

Copy link
Copy Markdown
MemberAuthor

@huonw yes.

@nrc

nrc commented Jun 10, 2015

Copy link
Copy Markdown
MemberAuthor

@nikomatsakis updated the text

@nikomatsakis

nikomatsakis commented Jun 10, 2015

Copy link
Copy Markdown
Contributor

It's official... the language subteam has decided to accept this RFC.

@nikomatsakis
nikomatsakis merged commit d69cf92 into rust-lang:masterJun 10, 2015
@CentrilCentril added A-expressions Term language related proposals & ideas A-ascription Type ascription related proposals & ideas A-machine Proposals relating to Rust's abstract machine. A-typesystem Type system related proposals & ideas labels Nov 23, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

A-ascriptionType ascription related proposals & ideasA-expressionsTerm language related proposals & ideasA-machineProposals relating to Rust's abstract machine.A-typesystemType system related proposals & ideasfinal-comment-periodWill be merged/postponed/closed in ~10 calendar days unless new substational objections are raised.T-langRelevant to the language team, which will review and decide on the RFC.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nrc@huonw@Ericson2314@nikomatsakis@Centril