Skip to content

Add Rollup Procedure - #268

Merged
Centril merged 7 commits into
rust-lang:masterfrom
XAMPPRocky:rollups
Oct 23, 2019
Merged

Add Rollup Procedure#268
Centril merged 7 commits into
rust-lang:masterfrom
XAMPPRocky:rollups

Conversation

@XAMPPRocky

@XAMPPRockyXAMPPRocky commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

This PR is a continuation of #87 with what @Centril has written about the current rollup procedure.

r? @Centril

Centril
Centril reviewed Oct 20, 2019
View reviewed changes
Comment threadsrc/release/rollups.md Outdated
Comment threadsrc/release/rollups.md Outdated
Comment threadsrc/release/rollups.md Outdated
Comment threadsrc/release/rollups.md Outdated
Comment threadsrc/release/rollups.md Outdated
Comment threadsrc/release/rollups.md
Comment threadsrc/release/rollups.md
Comment threadsrc/release/rollups.md Outdated
Comment threadsrc/release/rollups.md Outdated
Centril
Centril reviewed Oct 20, 2019
View reviewed changes
Comment threadsrc/release/rollups.md Outdated
XAMPPRockyand others added 2 commits October 21, 2019 09:06
@XAMPPRocky@Centril
Update src/release/rollups.md
7221367
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@XAMPPRocky@Centril
Apply suggestions from code review
c220649
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@XAMPPRockyXAMPPRocky mentioned this pull request Oct 21, 2019
Closed
Centril
Centril reviewed Oct 21, 2019
View reviewed changes
Comment threadsrc/release/rollups.md Outdated
JohnTitor
JohnTitor reviewed Oct 21, 2019
View reviewed changes
Comment threadsrc/release/rollups.md Outdated
@XAMPPRocky@JohnTitor
Update src/release/rollups.md
0ebf014
Co-Authored-By: Yuki Okushi <huyuumi.dev@gmail.com>
JohnTitor
JohnTitor reviewed Oct 23, 2019
View reviewed changes
Comment threadsrc/release/rollups.md Outdated
XAMPPRockyand others added 2 commits October 23, 2019 12:48
@XAMPPRocky@JohnTitor
Update src/release/rollups.md
7f6eca7
Co-Authored-By: Yuki Okushi <huyuumi.dev@gmail.com>
@XAMPPRocky
Update rollups.md
dc2db65
@XAMPPRocky

XAMPPRocky commented Oct 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@Centril Updated, could you re-review it?

Centril
Centril reviewed Oct 23, 2019
View reviewed changes
Comment threadsrc/release/rollups.md Outdated
PR, `@bors rollup-` to un-mark as a rollup). 'Performing a Rollup' then means
collecting these changes into one PR and merging them all at once. The rollup
command accepts three values `always`, `maybe`, and `never`. `@bors rollup` is
equivalent to `rollup=always` (which will always put a PR in a rollup), and

@CentrilCentrilOct 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these commands, aside from rollup (which will make the priority effectively negative) don't actually have any automatic effect like that; it is a suggestion to the person making a rollup.

@XAMPPRockyXAMPPRockyOct 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded to make that distinction more clear.

@Centril
Centril merged commit 414dbc4 into rust-lang:masterOct 23, 2019
@Centril

Centril commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

Thanks!

@XAMPPRocky
XAMPPRocky deleted the rollups branch October 23, 2019 17:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor left review comments
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XAMPPRocky@Centril@JohnTitor