Uh oh!
There was an error while loading. Please reload this page.
Elaborate all box dereferences in ElaborateBoxDerefs - #100034
Merged
Merged
Conversation
rustbot
commented
Aug 1, 2022
Collaborator
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
nagisa
commented
Aug 7, 2022
Member
r? @oli-obk to go with the other PR. |
bors
commented
Aug 9, 2022
Collaborator
☔ The latest upstream changes (presumably #100089) made this pull request unmergeable. Please resolve the merge conflicts. |
tmiaskoforce-pushed
the
elaborate-box-derefs
branch
from
August 24, 2022 20:46
9612eb9 to
14d79f2CompareA resume place is evaluated and assigned to only after a yield terminator resumes. Ensure that locals used when evaluating the resume place are live across the yield.
tmiaskoforce-pushed
the
elaborate-box-derefs
branch
from
August 25, 2022 05:12
14d79f2 to
31fae68Compareoli-obk
reviewed
Aug 25, 2022
Comment on lines
140
to
144
Contributor
There was a problem hiding this comment.
There's now 3 duplications of this logic, maybe give it a helper function?
oli-obk
approved these changes
Aug 25, 2022
oli-obk
left a comment
Contributor
There was a problem hiding this comment.
This is really nice work!
r=me with nit addressed
so that it is the only pass responsible for elaboration, instead of splitting this responsibility between the `StateTransform` and `ElaborateBoxDerefs`.
tmiaskoforce-pushed
the
elaborate-box-derefs
branch
from
August 25, 2022 08:46
31fae68 to
4394ea8Compareoli-obk
commented
Aug 25, 2022
Contributor
@bors r+ |
bors
commented
Aug 25, 2022
Collaborator
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 25, 2022
…i-obk Elaborate all box dereferences in `ElaborateBoxDerefs` so that it is the only pass responsible for elaboration, instead of splitting this responsibility between the `StateTransform` and `ElaborateBoxDerefs`.
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 25, 2022
…i-obk Elaborate all box dereferences in `ElaborateBoxDerefs` so that it is the only pass responsible for elaboration, instead of splitting this responsibility between the `StateTransform` and `ElaborateBoxDerefs`.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 26, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#99064 (distinguish the method and associated function diagnostic information) - rust-lang#99920 (Custom allocator support in `rustc_serialize`) - rust-lang#100034 ( Elaborate all box dereferences in `ElaborateBoxDerefs`) - rust-lang#100076 (make slice::{split_at,split_at_unchecked} const functions) - rust-lang#100604 (Remove unstable Result::into_ok_or_err) - rust-lang#100933 (Reduce code size of `assert_matches_failed`) - rust-lang#100978 (Handle `Err` in `ast::LitKind::to_token_lit`.) - rust-lang#101010 (rustdoc: remove unused CSS for `.multi-column`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that it is the only pass responsible for elaboration, instead of
splitting this responsibility between the
StateTransformandElaborateBoxDerefs.